Common: added reference run number to ReferenceComparator plots #2569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aferrero2707
requested review from
Barthelemy,
justonedev1 and
knopers8
as code owners
Contributor
Author
|
Here is how the legend and the title look like with the new code: |
The number of the reference run is reported both in the title of the ratio plot, and in a legend at the top of the superimposed histograms.
aferrero2707
force-pushed
the
common-add-reference-run-number-in-reference-comparator-plots
branch
from
7f706ca to
09c1ac1
Compare
Contributor
Author
|
@Barthelemy @knopers8 @justonedev1 could please have a look if you agree with the changes? Thanks! |
Collaborator
|
@aferrero2707 Sorry for the delay, I am going to review it by tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of the reference run is reported both in the title of the ratio plot, and in a legend at the top of the superimposed histograms.