ITS Track Check returns Null Quality by default #2470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initializing Quality result with 0 had an effect of producing a Quality without a name and with level 0, which is treated as "not worse than Good". This does not seem like an intentional behaviour, so I am proposing to use the default Null Quality instead. Precautions will be taken in the framework, so that it cannot be done anymore.
Barthelemy
approved these changes
Nov 7, 2024
Collaborator
Author
IsakovAD
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializing Quality result with 0 had an effect of producing a Quality without a name and with level 0, which is treated as "not worse than Good". This does not seem like an intentional behaviour, so I am proposing to use the default Null Quality instead. Precautions will be taken in the framework, so that it cannot be done anymore.