Skip to content

[OCTRL-1051] Missing Error & Done Kafka events for early failed NewAutoEnvironment #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knopers8 merged 1 commit into from
Oct 15, 2025
Merged

[OCTRL-1051] Missing Error & Done Kafka events for early failed NewAutoEnvironment #757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions core/environment/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1281,6 +1281,19 @@ func (envs *Manager) CreateAutoEnvironment(workflowPath string, userVars map[str
} else {
log.WithError(err).Logf(logrus.FatalLevel, "environment creation failed")
env.sendEnvironmentEvent(&event.EnvironmentEvent{EnvironmentID: newEnvId.String(), Error: err})
the.EventWriterWithTopic(topic.Environment).WriteEvent(&evpb.Ev_EnvironmentEvent{
EnvironmentId: newId.String(),
State: "ERROR",
Error: err.Error(),
Message: "cannot create new environment", // GUI listens for this concrete string
LastRequestUser: lastRequestUser,
WorkflowTemplateInfo: &evpb.WorkflowTemplateInfo{
Path: workflowPath,
Public: workflowPublicInfo.IsPublic,
Name: workflowPublicInfo.Name,
Description: workflowPublicInfo.Description,
},
})
return
}

Expand Down Expand Up @@ -1330,6 +1343,23 @@ func (envs *Manager) CreateAutoEnvironment(workflowPath string, userVars map[str
if err != nil {
err = fmt.Errorf("cannot load workflow template: %w", err)
env.sendEnvironmentEvent(&event.EnvironmentEvent{EnvironmentID: env.Id().String(), Error: err})

log.WithError(err).Error("failed to load workflow")

the.EventWriterWithTopic(topic.Environment).WriteEvent(&evpb.Ev_EnvironmentEvent{
EnvironmentId: newId.String(),
State: "ERROR",
Error: err.Error(),
Message: "cannot load workflow", // GUI listens for this concrete string
LastRequestUser: lastRequestUser,
WorkflowTemplateInfo: &evpb.WorkflowTemplateInfo{
Path: workflowPath,
Public: workflowPublicInfo.IsPublic,
Name: workflowPublicInfo.Name,
Description: workflowPublicInfo.Description,
},
})

return
}

Expand Down