OCTRL 1042: Add run type to metrics calls #748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justonedev1
force-pushed
the
OCTRL-1042
branch
from
c5cae6d to
3430a73
Compare
justonedev1
force-pushed
the
OCTRL-1042
branch
from
3430a73 to
03053e9
Compare
justonedev1
changed the title
knopers8
approved these changes
Sep 3, 2025
| return runType | ||
| } | ||
|
|
||
| func NewContext(envId string, varStack map[string]string, timeout time.Duration) (context.Context, context.CancelFunc) { |
Collaborator
There was a problem hiding this comment.
since envId is typically present in varStack, one could consider extracting it from varStack to have one less argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds run type and env id to all of the metrics calls (hooks, callables, plugins) through context or other means.