Fix race condition in tests #747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justonedev1
force-pushed
the
fix_tests_racecondition
branch
from
62102fe to
37f8aa3
Compare
knopers8
reviewed
Aug 21, 2025
knopers8
reviewed
Aug 26, 2025
common/monitoring/monitoring.go
Outdated
|
|
||
| func Stop() { | ||
| if !IsRunning() { | ||
| srv := server.Swap(nil) |
Collaborator
There was a problem hiding this comment.
please apply the same renaming in Stop
justonedev1
force-pushed
the
fix_tests_racecondition
branch
from
eadca54 to
3494a46
Compare
knopers8
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the
panic: runtime error: invalid memory address or nil pointer dereferenceerror triggering in tests. It was caused by the racecondition betweenRun()andStop().Runis blocking so it has to be called in goroutine (that is on purpose so we can handle errors in core) so sometimesStop()is called to quickly beforeRunis done, so you could callListenAndServeon an empty object.Usage of atomic pointer is not strictly necessary for the fix of mentioned problem. But it assures that no goroutine will be stuck if we change global server too quickly. Usage of the atomic pointer doesn't cause any performance penalty as it just holds the global server and nothing more.
This bug couldn't influence production as we didn't call
Run()and immediatelyStop().