Skip to content

Conversation

@justonedev1
Copy link
Collaborator

@justonedev1 justonedev1 commented Jul 18, 2025

I went over hooks and added call duration monitoring to:

  1. hooks in general
  2. each callable in hooks
  3. every call in plugins that I found valuable - except BKP as it uses kafka now. If you think that I should add monitoring even to BKP plugin I will do so. It is also possible that I missed something.

@justonedev1 justonedev1 requested a review from knopers8 as a code owner July 18, 2025 14:41
@justonedev1 justonedev1 changed the title [core] Added monitoring to hooks and communication with outside services OCTRL-1033 Enhance monitoring with call durations Jul 18, 2025
@justonedev1 justonedev1 force-pushed the OCTRL-1033 branch 3 times, most recently from c747c95 to dbfc94a Compare July 22, 2025 14:42
@justonedev1
Copy link
Collaborator Author

@knopers8 tested, you can review

@justonedev1 justonedev1 force-pushed the OCTRL-1033 branch 3 times, most recently from e4417ca to 64016b0 Compare July 24, 2025 14:11
@justonedev1
Copy link
Collaborator Author

Latest changes:

  • I had to regenerate all protofiles as grpc generated with new enough protoc contain routing name inside the grpc file instead of piecing it together myself. As a part of this I regenerated everything as our grpc files are generated with hodgepodge of protocs. I can move this to different PR if you want, but it is in it's own unique commit so it doesn't pollute history.
  • monitoring is in call.go on 2 places: call.Call() which gives us the most granular measurement of duration possible of each process in whole hook, second place is the call.Start() in goroutine where we measure wrapped Call() function where we can see when call is time outed
  • monitoring in all integration plugins except bookkeeping as grpc interceptors
  • DCS specific monitoring in grpc streams implemented again as interceptors and also measurement of whole dcs communication

@justonedev1 justonedev1 requested a review from knopers8 July 29, 2025 13:25
Copy link
Collaborator

@knopers8 knopers8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

- we monitor every trigger
- we monitor every process run by a trigger (more granularity)
- we monitor outside communication with services defined in integration
- DCS: we monitor duration of it's stream Recv() function
- DCS: we monitor duration of whole gRPC stream communication for PFR,
SOR, EOR
@justonedev1 justonedev1 merged commit 7f18908 into master Jul 30, 2025
4 checks passed
@justonedev1 justonedev1 deleted the OCTRL-1033 branch July 30, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants