Skip to content

[core] Demote cleanup script failures to Support #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knopers8 merged 1 commit into from
Jul 10, 2025
Merged

[core] Demote cleanup script failures to Support #729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/environment/transition_deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ func (t DeployTransition) do(env *Environment) (err error) {
localErr = cmd.Run()
if localErr != nil {
log.WithField("partition", env.Id().String()).
WithField("level", infologger.IL_Support).
Warnf("cleanup script failed on %s : %s\n", flp, localErr.Error())
scriptErrors = multierror.Append(scriptErrors, fmt.Errorf("cleanup unsuccessful on %s: %w", flp, localErr))
} else {
Expand Down Expand Up @@ -197,6 +198,7 @@ func (t DeployTransition) do(env *Environment) (err error) {
}
if err != nil {
log.WithField("partition", env.Id().String()).
WithField("level", infologger.IL_Ops).
Warnf("pre-deployment cleanup, %s", err.Error())
err = nil // we don't want to fail the deployment because of pre-deploy cleanup issues
}
Expand Down