[OCTRL-1016]: Missing runNumber in KafkaEvent on topic aliecs.run

[justonedev1]

I moved resetting of currentRunNumber from StartActivityTransition object if some tasks fail to start to GO_ERROR transition after message of EOEOR is send.

@knopers8 Do you think that this can break something? Or do you propose something else?

[knopers8]

20 lines lower there is this:

				if e.Event == "STOP_ACTIVITY" {
					// If the event is STOP_ACTIVITY, we remove the active run number after all hooks are done.
					env.workflow.GetVars().Set("last_run_number", strconv.Itoa(int(env.currentRunNumber)))
					env.currentRunNumber = 0
					env.workflow.GetVars().Del("run_number")
					env.workflow.GetVars().Del("runNumber")
				}

Shouldn't we just modify it so that it also deletes run numbers in case of GO_ERROR? We have to keep in mind though that GO_ERROR may not necessarily happen during RUNNING, but also in other states.

[knopers8]

I am suggesting this, because the GO_ERROR hooks with positive weights should still have access to run number.

[justonedev1]

We talked about multiple possibilities, but I kinda don't understand why just adding GO_ERROR isn't enough here, it should happen after all hooks are handled.

[knopers8]

i think we should avoid setting "last_run_number" if env.currentRunNumber is 0. This could happen if we e.g. reach ERROR without ever starting a run.

This way, it will be less risky to have a bug due to some piece of code assuming that non-empty last_run_number means we had a run before.