Kafka adjustments #699
Merged
Kafka adjustments #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justonedev1
force-pushed
the
kafka_adjustments
branch
from
7777e4f to
4b0a984
Compare
Collaborator
|
could you rebase please? |
justonedev1
force-pushed
the
kafka_adjustments
branch
from
4b0a984 to
7a1243b
Compare
Collaborator
Author
|
sorry for closing the PR, I am not sure how it happened :) |
Collaborator
Author
|
@knopers8 it should be rebased now |
knopers8
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is follow up on OCTRL-1003 with changes to kafka which I used to test metrics on STG and openstack. Just small tuneup of kafka-go producer, so it does not take 1s to send batch of messages which is incomplete (not 100 messages).
This branch is based on OCTRL-1003 (to distinguish metrics changes and kafka changes) so that one should be merged first to see real changes just in writer.go and writer_test.go