[core] OCTRL-1003 #698
[core] OCTRL-1003 #698
Conversation
justonedev1
force-pushed
the
OCTRL-1003
branch
3 times, most recently
from
460e7b4 to
19c9a33
Compare
knopers8
left a comment
knopers8
left a comment
There was a problem hiding this comment.
Thanks a lot! I see no fundamental problems, but I would propose some readability improvements. Also, please add a markdown file in docs summarizing the monitoring system in ECS (design overview, configuration and usage).
|
I will add docs as next step, I just wanted to address all the remarks, so you can take a look. I also resolved some conversations that I addressed in the fixup commit |
Thanks, the fixes look good. |
docs/metrics.md
Outdated
| types of metrics. This means that if you send metrics with | ||
| same measurement name and tags, but different timestamps (unix in nanoseconds) | ||
| but difference under one second all of them will be aggregated into | ||
| one bucket, where timestamp is rounded down at seconds. |
There was a problem hiding this comment.
This means that if you send metrics with
same measurement name and tags, but different timestamps (unix in nanoseconds)
but difference under one second all of them will be aggregated into
one bucket, where timestamp is rounded down at seconds.
I can't understand this sentence, could you rephrase?
docs/metrics.md
Outdated
| If either measurement or tags are different, than the metrics | ||
| wont' be grouped but every one of these metrics will be separate. If metric |
There was a problem hiding this comment.
| If either measurement or tags are different, than the metrics | |
| wont' be grouped but every one of these metrics will be separate. If metric | |
| If either measurement or tags are different than the metrics | |
| won't be grouped, but every one of these metrics will be separate. If metric |
docs/metrics.md
Outdated
| scraping requests from `http.Server` endpoint. As the http endpoint is called | ||
| different goroutine than the one processing event loop, we use another two channels: |
There was a problem hiding this comment.
| scraping requests from `http.Server` endpoint. As the http endpoint is called | |
| different goroutine than the one processing event loop, we use another two channels: | |
| scraping requests from `http.Server` endpoint. As the http endpoint is called | |
| by a different goroutine than the one processing event loop, we use another two channels: |
|
By the way, I have some fixup commits, so please don't merge, I need to remove them before. |
-aggregating metrics so we don't flod influxdb -changed json to influxdb line format to properly handle tags
-aggregating metrics so we don't flod influxdb
-changed json to influxdb line format to properly handle tags