Skip to content

[core] fix incorrect Sprintf usage in CCDB plugin #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justonedev1 merged 1 commit into from
May 2, 2025
Merged

[core] fix incorrect Sprintf usage in CCDB plugin #696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions core/integration/ccdb/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,12 +536,12 @@ func (p *Plugin) uploadCurrentGRP(grp *GeneralRunParameters, envId string, refre
strings.Join(grp.detectors, ","), strings.Join(grp.triggeringDetectors, ","), strings.Join(grp.continuousReadoutDetectors, ","))
cmdStr, err := p.NewCcdbGrpWriteCommand(grp, p.ccdbUrl, refresh)
if err != nil {
return errors.New(fmt.Sprintf("Failed to build a GRP to CCDB upload command: " + err.Error()))
return errors.New("Failed to build a GRP to CCDB upload command: " + err.Error())
}
log.WithField("partition", envId).
WithField("run", grp.runNumber).
WithField("level", infologger.IL_Devel).
Debug(fmt.Sprintf("CCDB GRP upload command: '" + cmdStr + "'"))
Debugf("CCDB GRP upload command: '%s'", cmdStr)

const timeoutSeconds = 10
ctx, cancel := context.WithTimeout(context.Background(), timeoutSeconds*time.Second)
Expand All @@ -555,10 +555,10 @@ func (p *Plugin) uploadCurrentGRP(grp *GeneralRunParameters, envId string, refre
WithField("run", grp.runNumber).
Debug("CCDB GRP upload command out: " + string(cmdOut))
if ctx.Err() == context.DeadlineExceeded {
return errors.New(fmt.Sprintf("The command to upload GRP to CCDB timed out (" + strconv.Itoa(timeoutSeconds) + "s)."))
return errors.New("The command to upload GRP to CCDB timed out (" + strconv.Itoa(timeoutSeconds) + "s).")
}
if err != nil {
return errors.New(fmt.Sprintf("Failed to run the command to upload GRP to CCDB: " + err.Error() + "\ncommand out : " + string(cmdOut)))
return errors.New("Failed to run the command to upload GRP to CCDB: " + err.Error() + "\ncommand out : " + string(cmdOut))
}
return nil
}
Expand Down