[OCTRL-948] Failing to deploy non-critical tasks should not prevent deployment #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knopers8
reviewed
Apr 1, 2025
| }) | ||
|
|
||
| When("Aggregate role is merged with any status (except UNDEFINED) status", func() { | ||
| It("becomes UNDEFINED", func() { |
Collaborator
There was a problem hiding this comment.
I assume this is expected because the aggregator role is empty? If so, perhaps make it clearer in "When("Empty aggregate role is...".
| }, | ||
| }, | ||
| } | ||
| ar.status.merge(task.INACTIVE, ar) |
Collaborator
There was a problem hiding this comment.
Since task.INACTIVE is basically ignored, perhaps add a short comment that this is expected (here and in further cases down). I understand this behaviour does not come in this PR, but it is quite counter-intuitive, so we should avoid our own confusion later.
Collaborator
Author
|
I addressed the comments and also did the tests on staging. But if you aprove this, dont merge I need to squash the fixup commit |
INVARIANT status is introduced to fix OCTRL-948. INVARIANT is overwritten by any other status in status product (X() function). We are taking account the criticality of the role when merging. If all roles are noncritical we are returning INVARIANT. If there is any critical role(s) we are merging and returning their status, which shouldn't be INVARIANT. All roles except taskRole and callrole are taken as critical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INVARIANT status is introduced to fix OCTRL-948. INVARIANT is overwritten by any other status in status product (X() function). We are taking account the criticality of the role when merging. If all roles are noncritical we are returning INVARIANT. If there is any critical role(s) we are merging and returning their status, which shouldn't be INVARIANT. All roles except taskRole and callrole are taken as critical