.swiftinterface file support
#21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Sources/Pipeline/Modules/SwiftPackageFileAnalyzer.swift # Sources/Pipeline/SDKDumpPipeline.swift # Tests/UnitTests/PipelineTests.swift # Tests/UnitTests/SDKDumpAnalyzerTests.swift # Tests/UnitTests/SwiftPackageFileAnalyzerTests.swift
# Conflicts: # Package.swift
…swift-public-api-diff into swiftinterface-file-support
|
It's quite impossible to review, any particular part to look for? Otherwise, I'd just approve |
Contributor
Author
I'll go through the major changes tomorrow :) |
* Moving files around * Better modularization * Removing unused code * More modularization * fixing Package.swift file * some fixes * Renaming * Renaming * Renaming * More renaming * Restructuring * Adding swift-docc plugin --------- Co-authored-by: Alex Guretzki <alexander.guretzki@adyen.com>
to make them visible on github
atmamont
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The public api diff now uses
swift-syntaxto parse.swiftinterfacefiles instead of relying on abi.json files that can be incomplete and do not expose features likeactor,async, ...TODOs
Target structure
Executable Targets
Public Modules
SwiftInterfaceFiles, package-changes + warningsSwiftInterfaceFilesSwiftInterfaceFileShared/Public
Shared/Package
See: #13