Providing a way to store SCP in experience fragments #2930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 20, 2021 15:49
…de to allow for Shared Component Properties
Adobe-Consulting-Services#2742 - Providing a way to localize list titles
…/acs-aem-commons into Adobe-Consulting-Services-master
Codecov Report
@@ Coverage Diff @@
## master #2930 +/- ##
=========================================
Coverage 54.05% 54.05%
Complexity 5609 5609
=========================================
Files 756 756
Lines 30779 30779
Branches 3978 3978
=========================================
Hits 16637 16637
Misses 12594 12594
Partials 1548 1548 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
|
@Derthenier looks good - are there possibilities of conflicting w/ people that are already overlaying this space? Could we collide/overwrite with some else's customization? |
…-experience-fragment-folder-structure
…-experience-fragment-folder-structure
Contributor
Author
|
It is possible that it will create conflicts for people extending the experience fragments |
Contributor
|
I wonder if we just package this up and link to it from the docs page? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling shared component nodes in experience fragment folder structure