Skip to content

GlslRender was hardcoding SRGB even is framebuffer was set to raw #2523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JGamache-autodesk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GlslRender was hardcoding SRGB even is framebuffer was set to raw #2523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/MaterialXRenderGlsl/GLFramebuffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ GLFramebuffer::GLFramebuffer(unsigned int width, unsigned int height, unsigned i
_height(height),
_channelCount(channelCount),
_baseType(baseType),
_encodeSrgb(false),
_encodeSrgb(true),
Copy link
Contributor Author

@JGamache-autodesk JGamache-autodesk Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made it the default, since GlslRenderer was enforcing it for so long.

_framebuffer(0),
_colorTexture(0),
_depthTexture(0)
Expand Down
3 changes: 1 addition & 2 deletions source/MaterialXRenderGlsl/GlslRenderer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,13 +151,12 @@ void GlslRenderer::render()
throw ExceptionRenderError("Invalid OpenGL context in render");
}

// Set up target
// Set up target. Will manage GL_FRAMEBUFFER_SRGB.
_framebuffer->bind();

glClearColor(_screenColor[0], _screenColor[1], _screenColor[2], 1.0f);

glEnable(GL_DEPTH_TEST);
glEnable(GL_FRAMEBUFFER_SRGB);
glDepthFunc(GL_LESS);
glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);

Expand Down