Skip to content

Commit 6d8dfdd

Browse files
arcanedev-marocarcanedev-maroc
authored
Merge pull request #23 from ARCANEDEV/update-laravel_5.8
Adding Laravel 5.8 support
2 parents 18b24cb + 0ee29c9 commit 6d8dfdd

File tree

8 files changed

+21
-30
lines changed

8 files changed

+21
-30
lines changed

‎LICENSE.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
The MIT License (MIT)
22

3-
Copyright (c) 2016-2018 | ARCANEDEV <arcanedev.maroc@gmail.com> - Laravel Notes
3+
Copyright (c) 2016-2019 | ARCANEDEV <arcanedev.maroc@gmail.com> - Laravel Notes
44

55
Permission is hereby granted, free of charge, to any person obtaining a copy
66
of this software and associated documentation files (the "Software"), to deal

‎README.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ This Laravel Notes will allow you to add a notes system into your Laravel projec
2020
* Easy setup &amp; configuration.
2121
* Well documented &amp; IDE Friendly.
2222
* Well tested with maximum code quality.
23-
* Laravel `5.1` to `5.7` are supported.
23+
* Laravel `5.1` to `5.8` are supported.
2424
* Made with :heart: &amp; :coffee:.
2525

2626
## Table of contents
@@ -42,7 +42,7 @@ If you discover any security related issues, please email arcanedev.maroc@gmail.
4242
- [ARCANEDEV][link-author]
4343
- [All Contributors][link-contributors]
4444

45-
[badge_laravel]: https://img.shields.io/badge/For%20Laravel-5.1%20to%205.7-orange.svg?style=flat-square
45+
[badge_laravel]: https://img.shields.io/badge/For%20Laravel-5.1%20to%205.8-orange.svg?style=flat-square
4646
[badge_license]: https://img.shields.io/packagist/l/arcanedev/laravel-notes.svg?style=flat-square
4747
[badge_build]: https://img.shields.io/travis/ARCANEDEV/LaravelNotes.svg?style=flat-square
4848
[badge_coverage]: https://img.shields.io/scrutinizer/coverage/g/ARCANEDEV/LaravelNotes.svg?style=flat-square

‎_docs/0-Home.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ This Laravel Notes will allow you to add a notes system into your Laravel projec
88
* Easy setup &amp; configuration.
99
* Well documented &amp; IDE Friendly.
1010
* Well tested with maximum code quality.
11-
* Laravel `5.1` to `5.7` are supported.
11+
* Laravel `5.1` to `5.8` are supported.
1212
* Made with :heart: &amp; :coffee:.
1313

1414
## Table of contents

‎_docs/1-Installation-and-Setup.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ The Laravel Notes package has a few system requirements:
2323
| ![Laravel Notes v2.x][laravel_notes_2_x] | ![Laravel v5.5][laravel_5_5] |
2424
| ![Laravel Notes v3.x][laravel_notes_3_x] | ![Laravel v5.6][laravel_5_6] |
2525
| ![Laravel Notes v4.x][laravel_notes_4_x] | ![Laravel v5.7][laravel_5_7] |
26+
| ![Laravel Notes v5.x][laravel_notes_5_x] | ![Laravel v5.8][laravel_5_8] |
2627

2728
[laravel_5_1]: https://img.shields.io/badge/v5.1-supported-brightgreen.svg?style=flat-square "Laravel v5.1"
2829
[laravel_5_2]: https://img.shields.io/badge/v5.2-supported-brightgreen.svg?style=flat-square "Laravel v5.2"
@@ -31,12 +32,14 @@ The Laravel Notes package has a few system requirements:
3132
[laravel_5_5]: https://img.shields.io/badge/v5.5-supported-brightgreen.svg?style=flat-square "Laravel v5.5"
3233
[laravel_5_6]: https://img.shields.io/badge/v5.6-supported-brightgreen.svg?style=flat-square "Laravel v5.6"
3334
[laravel_5_7]: https://img.shields.io/badge/v5.7-supported-brightgreen.svg?style=flat-square "Laravel v5.7"
35+
[laravel_5_8]: https://img.shields.io/badge/v5.8-supported-brightgreen.svg?style=flat-square "Laravel v5.8"
3436

3537
[laravel_notes_0_x]: https://img.shields.io/badge/version-0.*-blue.svg?style=flat-square "LaravelNotes v0.*"
3638
[laravel_notes_1_x]: https://img.shields.io/badge/version-1.*-blue.svg?style=flat-square "LaravelNotes v1.*"
3739
[laravel_notes_2_x]: https://img.shields.io/badge/version-2.*-blue.svg?style=flat-square "LaravelNotes v2.*"
3840
[laravel_notes_3_x]: https://img.shields.io/badge/version-3.*-blue.svg?style=flat-square "LaravelNotes v3.*"
3941
[laravel_notes_4_x]: https://img.shields.io/badge/version-4.*-blue.svg?style=flat-square "LaravelNotes v4.*"
42+
[laravel_notes_5_x]: https://img.shields.io/badge/version-5.*-blue.svg?style=flat-square "LaravelNotes v5.*"
4043

4144
## Composer
4245

‎composer.json‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@
1515
"license": "MIT",
1616
"require": {
1717
"php": ">=7.1.3",
18-
"arcanedev/support": "~4.4.0"
18+
"arcanedev/support": "~4.5.0"
1919
},
2020
"require-dev": {
21-
"orchestra/testbench": "~3.7.0",
21+
"orchestra/testbench": "~3.8.0",
2222
"mockery/mockery": "~1.0",
23-
"phpunit/phpunit": "~7.0",
24-
"phpunit/phpcov": "~5.0"
23+
"phpunit/phpunit": "~7.0|~8.0",
24+
"phpunit/phpcov": "~5.0|~6.0"
2525
},
2626
"autoload": {
2727
"psr-4": {

‎tests/LaravelNotesServiceProviderTest.php‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,14 @@ class LaravelNotesServiceProviderTest extends TestCase
2323
| -----------------------------------------------------------------
2424
*/
2525

26-
public function setUp()
26+
public function setUp(): void
2727
{
2828
parent::setUp();
2929

3030
$this->provider = $this->app->getProvider(LaravelNotesServiceProvider::class);
3131
}
3232

33-
public function tearDown()
33+
public function tearDown(): void
3434
{
3535
unset($this->provider);
3636

@@ -49,7 +49,7 @@ public function it_can_be_instantiated()
4949
\Illuminate\Support\ServiceProvider::class,
5050
\Arcanedev\Support\ServiceProvider::class,
5151
\Arcanedev\Support\PackageServiceProvider::class,
52-
\Arcanedev\LaravelNotes\LaravelNotesServiceProvider::class,
52+
LaravelNotesServiceProvider::class,
5353
];
5454

5555
foreach ($expectations as $expected) {

‎tests/Models/NoteTest.php‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,12 @@
1414
*/
1515
class NoteTest extends TestCase
1616
{
17-
/* ------------------------------------------------------------------------------------------------
18-
| Has One Note Tests
19-
| ------------------------------------------------------------------------------------------------
17+
18+
/* -----------------------------------------------------------------
19+
| Tests [Has One Note]
20+
| -----------------------------------------------------------------
2021
*/
22+
2123
/** @test */
2224
public function it_can_create_a_note()
2325
{
@@ -129,7 +131,7 @@ public function it_can_reverse_relation()
129131
}
130132

131133
/* -----------------------------------------------------------------
132-
| Has Many Notes Tests
134+
| [Tests] Has Many Notes
133135
| -----------------------------------------------------------------
134136
*/
135137

‎tests/TestCase.php‎

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ abstract class TestCase extends BaseTestCase
2424
| -----------------------------------------------------------------
2525
*/
2626

27-
public function setUp()
27+
public function setUp(): void
2828
{
2929
parent::setUp();
3030

@@ -46,20 +46,6 @@ protected function getPackageProviders($app)
4646
];
4747
}
4848

49-
/**
50-
* Get package aliases.
51-
*
52-
* @param \Illuminate\Foundation\Application $app
53-
*
54-
* @return array
55-
*/
56-
protected function getPackageAliases($app)
57-
{
58-
return [
59-
//
60-
];
61-
}
62-
6349
/**
6450
* Define environment setup.
6551
*

0 commit comments

Comments
 (0)