Minor updates

Author: arcanedev-maroc

.scrutinizer.yml

@@ -23,7 +23,7 @@ checks:
 tools:
     external_code_coverage:
         timeout: 600
-        runs: 3
+        runs: 4
     php_code_sniffer:
         enabled: true
         config:

.travis.yml

@@ -1,11 +1,10 @@
 language: php
 
-sudo: false
-
 php:
   - 7.1.3
   - 7.1
   - 7.2
+  - 7.3
   - nightly
 
 matrix:

composer.json

@@ -19,9 +19,9 @@
     },
     "require-dev": {
         "orchestra/testbench": "~3.7.0",
+        "mockery/mockery":     "~1.0",
         "phpunit/phpunit":     "~7.0",
-        "phpunit/phpcov":      "~5.0",
-        "mockery/mockery": "~1.0"
+        "phpunit/phpcov":      "~5.0"
     },
     "autoload": {
         "psr-4": {

src/Models/Note.php

@@ -29,14 +29,20 @@ class Note extends AbstractModel
      *
      * @var array
      */
-    protected $fillable = ['content', 'author_id'];
+    protected $fillable = [
+        'content',
+        'author_id',
+    ];
 
     /**
      * The attributes excluded from the model's JSON form.
      *
      * @var array
      */
-    protected $hidden = ['noteable_id', 'noteable_type'];
+    protected $hidden = [
+        'noteable_id',
+        'noteable_type',
+    ];
 
     /**
      * The attributes that should be cast to native types.

src/Traits/HasManyNotes.php

@@ -50,9 +50,14 @@ public function createNote($content, $author = null, $reload = true)
             $this->prepareNoteAttributes($content, $author)
         );
 
-        $relations = array_merge(['notes'], method_exists($this, 'authoredNotes') ? ['authoredNotes'] : []);
+        if ($reload) {
+            $relations = array_merge(
+                ['notes'],
+                method_exists($this, 'authoredNotes') ? ['authoredNotes'] : []
+            );
 
-        if ($reload) $this->load($relations);
+            $this->load($relations);
+        }
 
         return $note;
     }
@@ -66,7 +71,7 @@ public function createNote($content, $author = null, $reload = true)
      */
     public function findNote($id)
     {
-        return $this->notes()->where('id', $id)->first();
+        return $this->notes()->find($id);
     }
 
     /* -----------------------------------------------------------------

src/Traits/HasOneNote.php

@@ -43,14 +43,16 @@ public function note()
      */
     public function createNote($content, $author = null, $reload = true)
     {
-        if ($this->note) $this->note->delete();
+        if ($this->note)
+            $this->note->delete();
 
         /** @var \Arcanedev\LaravelNotes\Models\Note $note */
         $note = $this->note()->create(
             $this->prepareNoteAttributes($content, $author)
         );
 
-        if ($reload) $this->load(['note']);
+        if ($reload)
+            $this->load(['note']);
 
         return $note;
     }