py: Fix Map.get() again

leoetlino · leoetlino · commit 95e7201df552 · 2020-05-05T22:13:33.000+02:00
diff --git a/py/pybind11_common.h b/py/pybind11_common.h
@@ -154,7 +154,7 @@ py::class_<Map, holder_type> BindMap(py::handle scope, const std::string& name,
                 }
                 return it->second;
               },
-              py::return_value_policy::reference_internal, "key"_a, "default"_a = std::nullopt)
+              "key"_a, "default"_a = std::nullopt, py::keep_alive<0, 1>())
           .def(
               "keys", [](const Map& map) { return py::make_key_iterator(map.begin(), map.end()); },
               py::keep_alive<0, 1>());

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,7 @@ py::class_<Map, holder_type> BindMap(py::handle scope, const std::string& name,`
`154`	`154`	`}`
`155`	`155`	`return it->second;`
`156`	`156`	`},`
`157`		`- py::return_value_policy::reference_internal, "key"_a, "default"_a = std::nullopt)`
	`157`	`+ "key"_a, "default"_a = std::nullopt, py::keep_alive<0, 1>())`
`158`	`158`	`.def(`
`159`	`159`	`"keys", [](const Map& map) { return py::make_key_iterator(map.begin(), map.end()); },`
`160`	`160`	`py::keep_alive<0, 1>());`