Arrow ipc Array -> Bytes codec #3613
Open
+227
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
rabernat
commented
Dec 3, 2025
src/zarr/core/metadata/v3.py
Outdated
| if isinstance(dtype, VariableLengthUTF8) and codec_class_name not in ( | ||
| "VLenUTF8Codec", | ||
| "ArrowIPCCodec", | ||
| ): # type: ignore[unreachable] |
Contributor
Author
There was a problem hiding this comment.
This change allows us to use either the vlen-bytes or the arrow-ipc codec to encode variable length strings.
Flagging that this sort of logic for mapping codec / dtype compatibility feels quite brittle and non-scalable. But I don't have a better proposal in mind.
Contributor
There was a problem hiding this comment.
i feel the same way! we might need a dtype x codecs compatibility matrix, not sure if it should track compatibility or incompatibility
Contributor
Author
|
@d-v-b - resolving the typing errors here is beyond my ability. Would appreciate your help. 🙏 |
Contributor
|
ci is passing via 96273a8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of
arrow-ipcArray Bytes codec proposed in zarr-developers/zarr-extensions#41TODO:
docs/user-guide/*.mdchanges/