gitlab: Fix other limits issues

As explained in the previous commit, there are instances in which
the incorrect number of items were returned.  Fix up two other instances
of the same issue in the Project snippet and Issue list code.

Signed-off-by: Prarit Bhargava <prarit@redhat.com>

Author: prarit

internal/gitlab/gitlab.go

@@ -669,19 +669,26 @@ func IssueGet(projID interface{}, id int) (*gitlab.Issue, error) {
 
 // IssueList gets a list of issues on a GitLab Project
 func IssueList(projID interface{}, opts gitlab.ListProjectIssuesOptions, n int) ([]*gitlab.Issue, error) {
-	if n == -1 {
-		n = maxItemsPerPage
-	}
-
 	var list []*gitlab.Issue
-	for len(list) < n {
-		opts.PerPage = n - len(list)
+	for true {
+		opts.PerPage = maxItemsPerPage
+		if n != -1 {
+			opts.PerPage = n - len(list)
+			if opts.PerPage > maxItemsPerPage {
+				opts.PerPage = maxItemsPerPage
+			}
+		}
+
 		issues, resp, err := lab.Issues.ListProjectIssues(projID, &opts)
 		if err != nil {
 			return nil, err
 		}
 		list = append(list, issues...)
 
+		if len(list) == n {
+			break
+		}
+
 		var ok bool
 		if opts.Page, ok = hasNextPage(resp); !ok {
 			break
@@ -996,19 +1003,26 @@ func ProjectSnippetDelete(projID interface{}, id int) error {
 
 // ProjectSnippetList lists snippets on a project
 func ProjectSnippetList(projID interface{}, opts gitlab.ListProjectSnippetsOptions, n int) ([]*gitlab.Snippet, error) {
-	if n == -1 {
-		n = maxItemsPerPage
-	}
-
 	var list []*gitlab.Snippet
-	for len(list) < n {
-		opts.PerPage = n - len(list)
+	for true {
+		opts.PerPage = maxItemsPerPage
+		if n != -1 {
+			opts.PerPage = n - len(list)
+			if opts.PerPage > maxItemsPerPage {
+				opts.PerPage = maxItemsPerPage
+			}
+		}
+
 		snips, resp, err := lab.ProjectSnippets.ListSnippets(projID, &opts)
 		if err != nil {
 			return nil, err
 		}
 		list = append(list, snips...)
 
+		if len(list) == n {
+			break
+		}
+
 		var ok bool
 		if opts.Page, ok = hasNextPage(resp); !ok {
 			break