-
Notifications
You must be signed in to change notification settings - Fork 1
Bump dependencies and adjust #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zapodot
wants to merge
18
commits into
master
Choose a base branch
from
v1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
zapodot
commented
May 30, 2025
- 1.0 snapshot
- Build changes
- Build all branches
- Build all branches effort 2
- Needed to update parent
- Use jacoco + coveralls
- Bump jacoco
- Remove unused plugins
- Duplicate plugin
- Switcharoo
- Add mvn build wrapper
- Bump deps and adjust
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR primarily bumps dependency versions, removes unused plugins, and updates the Maven wrapper and CI configurations to support newer Java versions.
- Update dependency versions in pom.xml files (e.g., Guava, Java, JUnit, Jacoco).
- Remove unused plugins (coveralls, cobertura) and swap to a BOM-based dependency import for JUnit.
- Update Maven Wrapper scripts and GitHub workflow to use newer actions and Java versions.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Updated dependency versions and removed unused plugin entries. |
| mvnw.cmd, mvnw | Added/updated Maven Wrapper scripts for improved distribution setup. |
| embedded-jms-junit5/src/main/java/.../FieldInjector.java | Modified injection API to use TestInstances, but with potential logic issue. |
| embedded-jms-junit5/ and embedded-jms-junit/pom.xml | Bumped parent version and removed unused plugins. |
| embedded-jms-core/pom.xml | Adjusted test dependencies ordering to align with dependency updates. |
| .mvn/wrapper/maven-wrapper.properties | Added Maven wrapper properties. |
| .github/workflows/maven.yml | Updated CI configuration with newer Java versions and actions. |
| .github/dependabot.yml | Added schedule for GitHub Actions dependency updates. |
embedded-jms-junit5/src/main/java/org/zapodot/junit5/jms/internal/FieldInjector.java
Outdated
Show resolved
Hide resolved
…nal/FieldInjector.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.