Skip to content

Commit e7b3b87

Browse files
hughcapetFxKu
andauthored
Apply suggestions from code review
Co-authored-by: Felix Kunde <felix-kunde@gmx.de>
1 parent b0add68 commit e7b3b87

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/cluster/cluster.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -521,7 +521,7 @@ func (c *Cluster) compareStatefulSetWith(statefulSet *appsv1.StatefulSet) *compa
521521
}
522522
if changed, reason := c.compareAnnotations(c.Statefulset.Spec.VolumeClaimTemplates[i].Annotations, statefulSet.Spec.VolumeClaimTemplates[i].Annotations); changed {
523523
needsReplace = true
524-
reasons = append(reasons, fmt.Sprintf("new statefulset's annotations for volume %q does not match the current one: ", name)+reason)
524+
reasons = append(reasons, fmt.Sprintf("new statefulset's annotations for volume %q does not match the current one: %s", name, reason))
525525
}
526526
if !reflect.DeepEqual(c.Statefulset.Spec.VolumeClaimTemplates[i].Spec, statefulSet.Spec.VolumeClaimTemplates[i].Spec) {
527527
name := c.Statefulset.Spec.VolumeClaimTemplates[i].Name
@@ -826,7 +826,7 @@ func (c *Cluster) compareLogicalBackupJob(cur, new *batchv1.CronJob) (match bool
826826
return true, ""
827827
}
828828

829-
func (c *Cluster) ComparePodDisruptionBudget(cur, new *apipolicyv1.PodDisruptionBudget) (bool, string) {
829+
func (c *Cluster) comparePodDisruptionBudget(cur, new *apipolicyv1.PodDisruptionBudget) (bool, string) {
830830
//TODO: improve comparison
831831
if match := reflect.DeepEqual(new.Spec, cur.Spec); !match {
832832
return false, "new PDB spec does not match the current one"

0 commit comments

Comments
 (0)