apply feedback

Author: idanovinda

pkg/cluster/cluster.go

@@ -84,6 +84,7 @@ type Cluster struct {
 	userSyncStrategy spec.UserSyncer
 	deleteOptions    metav1.DeleteOptions
 	podEventsQueue   *cache.FIFO
+	replicationSlots map[string]interface{}
 
 	teamsAPIClient      teams.Interface
 	oauthTokenGetter    OAuthTokenGetter
@@ -141,6 +142,7 @@ func New(cfg Config, kubeClient k8sutil.KubernetesClient, pgSpec acidv1.Postgres
 		podEventsQueue:      podEventsQueue,
 		KubeClient:          kubeClient,
 		currentMajorVersion: 0,
+		replicationSlots:    make(map[string]interface{}),
 	}
 	cluster.logger = logger.WithField("pkg", "cluster").WithField("cluster-name", cluster.clusterName())
 	cluster.teamsAPIClient = teams.NewTeamsAPI(cfg.OpConfig.TeamsAPIUrl, logger)
@@ -375,6 +377,12 @@ func (c *Cluster) Create() error {
 		}
 	}
 
+	if len(c.Spec.Patroni.Slots) > 0 {
+		for slotName, desiredSlot := range c.Spec.Patroni.Slots {
+			c.replicationSlots[slotName] = desiredSlot
+		}
+	}
+
 	return nil
 }
 

pkg/cluster/sync.go

@@ -581,13 +581,14 @@ func (c *Cluster) checkAndSetGlobalPostgreSQLConfiguration(pod *v1.Pod, effectiv
 
 	slotsToSet := make(map[string]interface{})
 	// check if there is any slot deletion
-	for slotName, effectiveSlot := range effectivePatroniConfig.Slots {
+	for slotName, effectiveSlot := range c.replicationSlots {
 		if desiredSlot, exists := desiredPatroniConfig.Slots[slotName]; exists {
 			if reflect.DeepEqual(effectiveSlot, desiredSlot) {
 				continue
 			}
 		}
 		slotsToSet[slotName] = nil
+		delete(c.replicationSlots, slotName)
 	}
 	// check if specified slots exist in config and if they differ
 	for slotName, desiredSlot := range desiredPatroniConfig.Slots {
@@ -597,6 +598,7 @@ func (c *Cluster) checkAndSetGlobalPostgreSQLConfiguration(pod *v1.Pod, effectiv
 			}
 		}
 		slotsToSet[slotName] = desiredSlot
+		c.replicationSlots[slotName] = desiredSlot
 	}
 	if len(slotsToSet) > 0 {
 		configToSet["slots"] = slotsToSet