Skip to content

Commit 919ed3c

Browse files
committed
Fix: some CI issues and use jdk 25
1 parent e1e54e4 commit 919ed3c

File tree

4 files changed

+9
-15
lines changed

4 files changed

+9
-15
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,10 @@ jobs:
3535
with:
3636
submodules: recursive
3737

38-
- name: Set up JDK 24
38+
- name: Set up JDK 25
3939
uses: actions/setup-java@v5
4040
with:
41-
java-version: 24
41+
java-version: 25
4242
distribution: 'temurin'
4343
cache: 'gradle'
4444

@@ -80,14 +80,14 @@ jobs:
8080
if: always()
8181
uses: actions/upload-artifact@v4
8282
with:
83-
name: test-results-${{ matrix.os }}-java24
83+
name: test-results-${{ matrix.os }}-java25
8484
path: |
8585
build/reports/tests/
8686
build/test-results/
8787
8888
- name: Upload build artifacts
8989
if: success()
90-
uses: actions/upload-artifact@v4
90+
uses: actions/upload-artifact@v5
9191
with:
92-
name: build-artifacts-${{ matrix.os }}-java24
92+
name: build-artifacts-${{ matrix.os }}-java25
9393
path: build/libs/

README.md

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
## ⚠️ Status
66

77
This library is **alpha**—under work in progress. APIs may change and functionality is still incomplete. Contributions and bug reports are welcome!
8-
You can check out this [PR](https://github.com/yuvicc/java-bitcoinkernel/pull/4) section for more details.
98

109
## Overview
1110

@@ -17,10 +16,6 @@ You can check out this [PR](https://github.com/yuvicc/java-bitcoinkernel/pull/4)
1716
- Block validation - todo
1817
- Clean Java-native bindings via FFM with minimal overhead
1918

20-
## Building
21-
22-
We vendor Bitcoin Core’s `libbitcoinkernel` using a Git subtree targeting the `kernelApi` branch from your fork:
23-
2419
```bash
2520
git subtree pull \
2621
--prefix bitcoinkernel/bitcoin \
@@ -30,9 +25,8 @@ git subtree pull \
3025

3126
## Requirements
3227
- CMake
33-
- C++17 compiler (e.g. GCC/Clang)
34-
- Boost
35-
- JDK 25+ with FFM support
28+
- C++20 compiler (for compiling Bitcoin Core)
29+
- JDK 25 for compiling Java
3630

3731
Refer to Bitcoin Core [docs](https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md) for dependency specifics.
3832

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ dependencies {
1414

1515
java {
1616
toolchain {
17-
languageVersion = JavaLanguageVersion.of(24)
17+
languageVersion = JavaLanguageVersion.of(25)
1818
}
1919
}
2020

src/main/java/org/bitcoinkernel/jextract/bitcoinkernel_h.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public class bitcoinkernel_h extends bitcoinkernel_h$shared {
2626
// Load the bitcoinkernel library
2727
SymbolLookup lookup = null;
2828
try {
29-
System.loadLibrary("bitcoinkernel");
29+
System.loadLibrary("libbitcoinkernel");
3030
lookup = SymbolLookup.loaderLookup();
3131
} catch (UnsatisfiedLinkError e) {
3232
// Fall back to default lookup (LD_LIBRARY_PATH)

0 commit comments

Comments
 (0)