-
Notifications
You must be signed in to change notification settings - Fork 1.2k
docs: Add YugabyteDB smart driver features to Sequelize documentation #29496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add YugabyteDB smart driver features to Sequelize documentation #29496
Conversation
✅ Deploy Preview for infallible-bardeen-164bc9 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
16458e6 to
e4670d9
Compare
f1b8dfc to
e2fa65a
Compare
HarshDaryani896
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
aishwarya24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments.
|
Hey @aishwarya24 Most recent sequelize page: link |
| ##### Environment variables | ||
| The following table summarizes the environment variables available for configuring the YugabyteDB node-postgres smart driver: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashetkar These Env variables are common to the driver not just sequelize? Why is this table not here https://docs.yugabyte.com/stable/develop/drivers-orms/nodejs/yugabyte-node-driver/#step-2-set-up-the-database-connection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's specific to the driver. @krishna-yb let's add this info on the page linked above.
- Added subsection: Using the YugabyteDB Smart Driver - Explains how to use smart driver with sequelize-yugabytedb - Links to smart-drivers documentation - Shows package.json configuration - Simplified load balance properties section - Environment variables examples - Connection parameters examples - Removed detailed property table for brevity
- Add comprehensive environment variables table to yugabyte-node-driver.md - Include all standard PG env vars (PGHOST, PGPORT, PGDATABASE, PGUSER, PGPASSWORD) - Include YugabyteDB-specific env vars (PGLOADBALANCE, PGTOPOLOGYKEYS, PGYBSERVERSREFRESHINTERVAL) - Add mapping table showing environment variable to connection parameter correspondence - Add code examples showing how to set env vars in Node.js and shell - Update sequelize.md to clarify it shows 'some' not 'all' environment variables - Add cross-reference from Sequelize docs to complete env vars documentation
f43c5ec to
64a44e5
Compare
- Remove redundant detailed env vars table from yugabyte-node-driver.md - Keep only the mapping table showing env var to parameter correspondence - Add all standard PostgreSQL env vars (PGHOST, PGPORT, PGDATABASE, PGUSER, PGPASSWORD) - Include YugabyteDB-specific env vars (PGLOADBALANCE, PGTOPOLOGYKEYS, PGYBSERVERSREFRESHINTERVAL) - Remove note from yugabyte-node-driver.md (cleaner without it) - Update sequelize.md to link to complete env vars list - Clarify that load balancing env vars are only for @yugabytedb/pg package
ashetkar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Uh oh!
There was an error while loading. Please reload this page.