Skip to content

Conversation

@krishna-yb
Copy link
Contributor

@krishna-yb krishna-yb commented Nov 26, 2025

  • Added note about smart driver features in Step 2
  • New section: Using YugabyteDB Smart Driver features
    • Load balancing configuration and modes
    • Topology awareness for multi-region deployments
    • Connection string examples with smart driver parameters
    • Environment variables reference table
  • Examples showing how to enable load balancing with process.env
  • Documentation for all PGLOADBALANCE modes
  • Examples for topology-aware routing
  • Complete environment variables reference

@netlify
Copy link

netlify bot commented Nov 26, 2025

Deploy Preview for infallible-bardeen-164bc9 ready!

Name Link
🔨 Latest commit b986a4e
🔍 Latest deploy log https://app.netlify.com/projects/infallible-bardeen-164bc9/deploys/692fbac21e2ec40008866887
😎 Deploy Preview https://deploy-preview-29496--infallible-bardeen-164bc9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@krishna-yb krishna-yb force-pushed the docs-sequelize-smart-driver branch from 16458e6 to e4670d9 Compare November 26, 2025 09:13
@krishna-yb krishna-yb requested a review from ashetkar November 26, 2025 09:17
@krishna-yb
Copy link
Contributor Author

@krishna-yb krishna-yb force-pushed the docs-sequelize-smart-driver branch 3 times, most recently from f1b8dfc to e2fa65a Compare November 27, 2025 07:16
@krishna-yb
Copy link
Contributor Author

Copy link
Contributor

@HarshDaryani896 HarshDaryani896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@aishwarya24 aishwarya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments.

@krishna-yb
Copy link
Contributor Author

krishna-yb commented Nov 30, 2025

Hey @aishwarya24
Please take a look
I've addressed your comments

Most recent sequelize page: link

##### Environment variables
The following table summarizes the environment variables available for configuring the YugabyteDB node-postgres smart driver:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashetkar These Env variables are common to the driver not just sequelize? Why is this table not here https://docs.yugabyte.com/stable/develop/drivers-orms/nodejs/yugabyte-node-driver/#step-2-set-up-the-database-connection

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's specific to the driver. @krishna-yb let's add this info on the page linked above.

@ddhodge ddhodge added the area/documentation Documentation needed label Dec 1, 2025
@github-project-automation github-project-automation bot moved this to In progress in Documentation Dec 1, 2025
- Added subsection: Using the YugabyteDB Smart Driver
  - Explains how to use smart driver with sequelize-yugabytedb
  - Links to smart-drivers documentation
  - Shows package.json configuration
- Simplified load balance properties section
  - Environment variables examples
  - Connection parameters examples
  - Removed detailed property table for brevity
- Add comprehensive environment variables table to yugabyte-node-driver.md
- Include all standard PG env vars (PGHOST, PGPORT, PGDATABASE, PGUSER, PGPASSWORD)
- Include YugabyteDB-specific env vars (PGLOADBALANCE, PGTOPOLOGYKEYS, PGYBSERVERSREFRESHINTERVAL)
- Add mapping table showing environment variable to connection parameter correspondence
- Add code examples showing how to set env vars in Node.js and shell
- Update sequelize.md to clarify it shows 'some' not 'all' environment variables
- Add cross-reference from Sequelize docs to complete env vars documentation
@krishna-yb krishna-yb force-pushed the docs-sequelize-smart-driver branch from f43c5ec to 64a44e5 Compare December 2, 2025 15:27
krishna-yb and others added 3 commits December 2, 2025 15:42
- Remove redundant detailed env vars table from yugabyte-node-driver.md
- Keep only the mapping table showing env var to parameter correspondence
- Add all standard PostgreSQL env vars (PGHOST, PGPORT, PGDATABASE, PGUSER, PGPASSWORD)
- Include YugabyteDB-specific env vars (PGLOADBALANCE, PGTOPOLOGYKEYS, PGYBSERVERSREFRESHINTERVAL)
- Remove note from yugabyte-node-driver.md (cleaner without it)
- Update sequelize.md to link to complete env vars list
- Clarify that load balancing env vars are only for @yugabytedb/pg package
Copy link
Contributor

@ashetkar ashetkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krishna-yb krishna-yb merged commit fe081a7 into yugabyte:master Dec 3, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Documentation Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation Documentation needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants