more debug env vars and logging

Author: cameron-p-m

src/yb/rpc/outbound_call.cc

@@ -243,24 +243,17 @@ OutboundCall::OutboundCall(const RemoteMethod& remote_method,
   IncrementCounter(rpc_metrics_->outbound_calls_created);
   IncrementGauge(rpc_metrics_->outbound_calls_alive);
 
-  // Start an OpenTelemetry span for this RPC call
-  // Only create spans when there's an active parent context to reduce noise
   if (OtelTracing::HasActiveContext()) {
     otel_span_ = OtelTracing::StartSpan(Format("rpc.client $0", remote_method_.ToString()));
     if (otel_span_.IsActive()) {
-      LOG(INFO) << "[OTEL DEBUG] Created RPC span (child) for call_id=" << call_id_ 
-                << " method=" << remote_method_.ToString();
       otel_span_.SetAttribute("rpc.system", "yugabytedb");
       otel_span_.SetAttribute("rpc.service", remote_method_.service_name());
       otel_span_.SetAttribute("rpc.method", remote_method_.method_name());
       otel_span_.SetAttribute("rpc.call_id", static_cast<int64_t>(call_id_));
       if (controller_->timeout().Initialized()) {
-        otel_span_.SetAttribute("rpc.timeout_ms", 
-                                static_cast<int64_t>(controller_->timeout().ToMilliseconds()));
+        otel_span_.SetAttribute("rpc.timeout_ms", controller_->timeout().ToMilliseconds());
       }
     }
-  } else {
-    VLOG(3) << "[OTEL DEBUG] No active context, skipping RPC span creation for call_id=" << call_id_;
   }
 }
 

src/yb/util/otel_http_exporter.cc

@@ -32,7 +32,10 @@ SimpleOtlpHttpSender g_otlp_sender;
 }  // namespace
 
 SimpleOtlpHttpSender::SimpleOtlpHttpSender()
-    : service_name_("yugabyte"), enabled_(false) {}
+    : enabled_(false) {
+  const char* service_name_env = std::getenv("OTEL_SERVICE_NAME");
+  service_name_ = (service_name_env && service_name_env[0] != '\0') ? service_name_env : "yugabyte";
+}
 
 SimpleOtlpHttpSender::~SimpleOtlpHttpSender() = default;
 
@@ -56,15 +59,10 @@ bool SimpleOtlpHttpSender::SendSpan(const SimpleSpanData& span) {
 }
 
 bool SimpleOtlpHttpSender::SendSpans(const std::vector<SimpleSpanData>& spans) {
-  if (!IsEnabled()) {
-    VLOG(2) << "[OTEL] HTTP sender not enabled, skipping export";
+  if (!IsEnabled() || spans.empty()) {
     return true;
   }
 
-  if (spans.empty()) {
-    return true;  // Nothing to do
-  }
-
   std::string json_payload = SpansToJson(spans);
 
   LOG(INFO) << "[OTEL] Sending " << spans.size() << " span(s) to " << endpoint_;
@@ -124,7 +122,6 @@ std::string SimpleOtlpHttpSender::JsonEscape(const std::string& str) {
 std::string SimpleOtlpHttpSender::SpansToJson(const std::vector<SimpleSpanData>& spans) const {
   std::ostringstream json;
 
-  // OTLP JSON structure
   json << R"({"resourceSpans":[{"resource":{"attributes":[)";
   json << R"({"key":"service.name","value":{"stringValue":")" << JsonEscape(service_name_) << R"("}},)";
   json << R"({"key":"telemetry.sdk.language","value":{"stringValue":"cpp"}},)";
@@ -153,7 +150,6 @@ std::string SimpleOtlpHttpSender::SpansToJson(const std::vector<SimpleSpanData>&
     json << R"("startTimeUnixNano":")" << span.start_time_ns << R"(",)";
     json << R"("endTimeUnixNano":")" << span.end_time_ns << R"(",)";
 
-    // Attributes
     json << R"("attributes":[)";
     bool first_attr = true;
     for (size_t j = 0; j < span.string_attributes.size(); ++j) {
@@ -170,7 +166,6 @@ std::string SimpleOtlpHttpSender::SpansToJson(const std::vector<SimpleSpanData>&
     }
     json << "],";
 
-    // Status
     json << R"("status":{"code":)" << span.status_code;
     if (!span.status_message.empty()) {
       json << R"(,"message":")" << JsonEscape(span.status_message) << R"(")";
@@ -187,33 +182,29 @@ SimpleOtlpHttpSender& GetGlobalOtlpSender() {
 }
 
 void InitGlobalOtlpSenderFromEnv(const std::string& service_name) {
-  // Read endpoint from OTEL_EXPORTER_OTLP_ENDPOINT environment variable
   std::string endpoint;
   const char* endpoint_env = std::getenv("OTEL_EXPORTER_OTLP_ENDPOINT");
-  
+
   if (endpoint_env && endpoint_env[0] != '\0') {
-    // Per OTLP spec, OTEL_EXPORTER_OTLP_ENDPOINT is the base URL
-    // Append /v1/traces for the traces signal
     endpoint = endpoint_env;
-    // Only append /v1/traces if it's not already part of the URL
     if (endpoint.find("/v1/traces") == std::string::npos) {
-      // Remove trailing slash if present before appending
       if (!endpoint.empty() && endpoint.back() == '/') {
         endpoint.pop_back();
       }
       endpoint += "/v1/traces";
     }
   } else {
-    // Default endpoint for local development
     endpoint = "http://localhost:4318/v1/traces";
   }
-  
+
   g_otlp_sender.SetEndpoint(endpoint);
   LOG(INFO) << "[OTEL] HTTP exporter endpoint: " << endpoint;
 
-  // Set the service name (already resolved by caller)
-  g_otlp_sender.SetServiceName(service_name);
-  LOG(INFO) << "[OTEL] HTTP exporter service name: " << service_name;
+  const char* service_name_env = std::getenv("OTEL_SERVICE_NAME");
+  std::string resolved_service_name = (service_name_env && service_name_env[0] != '\0')
+      ? service_name_env : "yugabyte";
+  g_otlp_sender.SetServiceName(resolved_service_name);
+  LOG(INFO) << "[OTEL] HTTP exporter service name: " << resolved_service_name;
 }
 
 }  // namespace yb