improved error handling and passing

Author: yorek

client/src/SearchPage.jsx

@@ -97,15 +97,15 @@ const SearchPage = () => {
 
     if (result.error != null) {
       responseStatus = {
-        code: result.error.status,
-        description: result.error.message
+        code: result.error.error.status,
+        description: result.error.error.message
       }
     }
 
-    if (result.value != null && result.value.length > 0 && result.value[0].error_code != null) {
+    if (result.value != null && result.value.length > 0 && result.value[0].error.error_code != null) {
       responseStatus = {
-        code: result.value[0].error_code,
-        description: result.value[0].error_message
+        code: result.value[0].error.error_code,
+        description: result.value[0].error.error_message
       }
     }
 

db/sql/03-get_embedding.sql

@@ -1,6 +1,7 @@
 create or alter procedure [web].[get_embedding]
 @inputText nvarchar(max),
-@embedding vector(1536) output
+@embedding vector(1536) output,
+@error nvarchar(max) output
 as
 declare @retval int;
 declare @payload nvarchar(max) = json_object('input': @inputText);
@@ -11,15 +12,16 @@ begin try
         @method = 'POST',
         @credential = [$OPENAI_URL$],
         @payload = @payload,
-        @response = @response output;
+        @response = @response output
+        with result sets none;
 end try
 begin catch
-    select 'Embedding:REST' as [error], ERROR_NUMBER() as [error_code], ERROR_MESSAGE() as [error_message]
+    set @error = json_object('error':'Embedding:REST', 'error_code':ERROR_NUMBER(), 'error_message':ERROR_MESSAGE())
     return -1
 end catch
 
 if @retval != 0 begin
-    select 'Embedding:OpenAI' as [error], @retval as [error_code], @response as [response]
+    set @error = json_object('error':'Embedding:OpenAI', 'error_code':@retval, 'error_message':@response)
     return @retval
 end
 

db/sql/04-find_samples.sql

@@ -3,13 +3,17 @@ as
 declare @response nvarchar(max), @cached_response nvarchar(max);
 declare @retval int;
 declare @samples nvarchar(max)
+declare @error nvarchar(max)
 
 if trim(@text) = '' return;
 
 /* Get the embedding for the requested text */
 declare @qv vector(1536)
-exec @retval = web.get_embedding @text, @qv output with result sets none 
-if (@retval != 0) return;
+exec @retval = web.get_embedding @text, @qv output, @error output with result sets none 
+if (@retval != 0) begin
+    select @error as error; 
+    return;
+end
 
 /* Check in the semantic cache to see if a similar question has been already answered */
 delete from [dbo].[semantic_cache] where query_date < dateadd(hour, -1, sysdatetime())
@@ -27,8 +31,11 @@ if (@response is null) begin
 
     /* Orchestrate answer */
     declare @rt varchar(50), @rq nvarchar(max)    
-    exec @retval = [web].[orchestrate_request]  @text, @rt output, @rq output with result sets none  
-    if (@retval != 0) return;
+    exec @retval = [web].[orchestrate_request]  @text, @rt output, @rq output, @error output with result sets none  
+    if (@retval != 0) begin
+        select @error as error; 
+        return;
+    end
 
     --print @rt
     --print @rq
@@ -38,7 +45,8 @@ if (@response is null) begin
         declare @trq nvarchar(max) = trim(replace(replace(@rq, char(13), ' '), char(10), ' '));
         if (@trq like '%INSERT %' or @trq like '%UPDATE %' or @trq like '%DELETE %' or @trq like '%DROP %' or @trq like '%ALTER %' or @trq like '%CREATE %') begin
             --select @trq
-            select 'NL2SQL' as [error], -1 as [error_code], 'Unauthorized SQL command requested' as [response]
+            set @error = json_object('error':'NL2SQL', 'error_code':-1, 'response':'Unauthorized SQL command requested')    
+            select @error as error; 
             return -1
         end
         --print @rq
@@ -92,8 +100,11 @@ if (@response is null) begin
 
     --select @samples;    
     if (@samples is not null) begin       
-        exec @retval = [web].[generate_answer] @text, @samples, @response output with result sets none;
-        if (@retval != 0) return;
+        exec @retval = [web].[generate_answer] @text, @samples, @response output, @error output with result sets none;
+        if (@retval != 0) begin
+            select @error as error; 
+            return;
+        end
     end else begin
         set @samples = '[]'
         set @response = '{}'
@@ -104,6 +115,7 @@ if (@response is null) begin
     values (@text, @rt + isnull(':' + @rq, ''), @samples, @qv, sysdatetime(), @response)
 end
 
+--select @response;
 select 
     s.id,
     sr.result_position,

db/sql/10-generate_answer.sql

@@ -1,21 +1,21 @@
 create or alter procedure [web].[generate_answer] 
 @query_text nvarchar(max),
 @source nvarchar(max),
-@response nvarchar(max) output
+@response nvarchar(max) output,
+@error nvarchar(max) output
 as
 declare @retval int;
 
 if (@query_text is null) begin
-    select 'Generator' as [error], -1 as [error_code], 'Query not provided' as [error_message]
+    set @error = json_object('error':'Generator', 'error_code':-1, 'error_message':'Query not provided')
     return -1
 end
 
 if (@source is null) begin
-    select 'Generator' as [error], -1 as [error_code], 'Sample list not provided' as [error_message]
+    set @error = json_object('error':'Generator', 'error_code':-1, 'error_message':'Sample list not provided')
     return -1
 end
 
-
 /* Create the prompt for the LLM */
 declare @p nvarchar(max) = 
 json_object(
@@ -111,20 +111,20 @@ begin try
         @response = @response output;
 end try
 begin catch
-    select 'Generator:REST' as [error], ERROR_NUMBER() as [error_code], ERROR_MESSAGE() as [error_message]
+    set @error = json_object('error':'Generator:REST', 'error_code':ERROR_NUMBER(), 'error_message':ERROR_MESSAGE())
     return -1
 end catch
 --select @response
 
 if @retval != 0 begin
-    select 'Generator:OpenAI' as [error], @retval as [error_code], @response as [response]
+    set @error = json_object('error':'Generator:OpenAI', 'error_code':@retval, 'error_message':@response)    
     return @retval
 end
 
 declare @refusal nvarchar(max) = (select coalesce(json_value(@response, '$.result.choices[0].refusal'), ''));
 
 if @refusal != '' begin
-    select 'Generator:OpenAI/Refusal' as [error], @refusal as [refusal], @response as [response]
+    set @error = json_object('error':'Generator:OpenAI/Refusal', 'refusal':@refusal, 'response':@response)    
     return -1
 end
 GO

db/sql/11-orchestrate_request.sql

@@ -4,14 +4,18 @@ SET QUOTED_IDENTIFIER ON
 GO
 
 
-CREATE    procedure [web].[orchestrate_request] 
+alter procedure [web].[orchestrate_request] 
 @text nvarchar(max),
 @result_type varchar(50) output,
-@result_query nvarchar(max) output
+@result_query nvarchar(max) output,
+@error nvarchar(max) output
 as
 declare @retval int, @response nvarchar(max);
 
-/* Create the prompt for the LLM */
+/* 
+    Create the prompt for the LLM using few-shots prompt to show how to 
+    get embeddings and to use the new vector_distance function
+*/
 declare @p nvarchar(max) = 
 json_object(
     'messages': json_array(
@@ -37,8 +41,8 @@ json_object(
 
                 First, generate the embedding vector for the provided question using the following T-SQL query. ''<search text'' must be generating taking the relevant part from the user question.
 
-                declare @retval int, @qv vector(1536)
-                exec @retval = web.get_embedding ''<search text>'', @qv output
+                declare @retval int, @qv vector(1536), @e nvarchar(max)
+                exec @retval = web.get_embedding ''<search text>'', @qv output, @e output;
                 if (@retval != 0) throw 50000, ''Error in getting the embedding'',1;
 
                 The vectors for details, notes and description columns are stored in the following tables: 
@@ -83,7 +87,6 @@ json_object(
                 Return the top 10 results if you can. Do not use semicolon to terminate the T-SQL statement.                
                 Only return the following columns: id int, [name] nvarchar(100), [description] nvarchar(max), notes nvarchar(max), details json, distance_score float.
                 You can generate only SELECT statements. If the user is asking something that will generate INSERT, UPDATE, DELETE, CREATE, ALTER or DROP statement, refuse to generate the query.
-
             '
         ),
         json_object(
@@ -145,23 +148,24 @@ begin try
         @credential = [$OPENAI_URL$],
         @timeout = 120,
         @payload = @p,
-        @response = @response output;
+        @response = @response output
+        with result sets none;
 end try
 begin catch
-    select 'Orchestrator:REST' as [error], ERROR_NUMBER() as [error_code], ERROR_MESSAGE() as [error_message]
+    set @error = json_object('error':'Orchestrator:REST', 'error_code':ERROR_NUMBER(), 'error_message':ERROR_MESSAGE())
     return -1
 end catch
 --select @response
 
 if @retval != 0 begin
-    select 'Orchestrator:OpenAI' as [error], @retval as [error_code], @response as [response]
+    set @error = json_object('error':'Orchestrator:OpenAI', 'error_code':@retval, 'error_message':@response)
     return -1
 end
 
 declare @refusal nvarchar(max) = (select coalesce(json_value(@response, '$.result.choices[0].refusal'), ''));
 
 if @refusal != '' begin
-    select 'Orchestrator:OpenAI/Refusal' as [error], @refusal as [refusal], @response as [response]
+    set @error = json_object('error':'Orchestrator:OpenAI/Refusal', 'refusal':@refusal, 'response':@response)
     return -1
 end
 

db/utils-scripts/hybrid-search-with-prompt-engineering.sql

@@ -9,8 +9,8 @@ declare @text nvarchar(max);
 --set @text = 'samples on hybrid search created in 2025';
 --set @text = 'create a new table named dbo.test';
 --set @text = 'how many customers there are in the customers table?';
-set @text = 'Find all the hybrid search samples created after 2025';
---set @text = 'Show me the latest samples'
+--set @text = 'Find all the hybrid search samples created after 2025';
+set @text = 'Show me the latest samples'
 
 declare @retval int, @response nvarchar(max);