Merge pull request #1764 from bstaletic/regex-optional

Make building regex module optional

Author: mergify[bot]

build.py

@@ -568,6 +568,10 @@ def ParseArguments():
   parser.add_argument( '--js-completer', action = 'store_true',
                        help = argparse.SUPPRESS )
 
+  parser.add_argument( '--regex', action = argparse.BooleanOptionalAction,
+                       default = True,
+                       help = 'Choose whether to build the regex module. '
+                              'Defaults to True.' )
   args = parser.parse_args()
 
   # coverage is not supported for c++ on MSVC
@@ -800,8 +804,8 @@ def BuildRegexModule( script_args ):
                  exit_message = 'Failed to build regex module.',
                  quiet = script_args.quiet,
                  status_message = 'Building regex module' )
-    except ImportError:
-      pass # Swallow the error - ycmd will fall back to the standard `re`.
+    except ( ImportError, subprocess.CalledProcessError ):
+      print( 'Building regex module failed. Falling back to re builtin.' )
 
   finally:
     RemoveDirectoryIfExists( build_dir )
@@ -1301,9 +1305,13 @@ def DoCmakeBuilds( args ):
   BuildYcmdLib( cmake, cmake_common_args, args )
   WritePythonUsedDuringBuild()
 
-  BuildRegexModule( args )
   BuildWatchdogModule( args )
 
+  # NOTE: Keep BuildRegexModule() as the final step.
+  # If it fails, at least everything mandatory has been built.
+  if args.regex:
+    BuildRegexModule( args )
+
 
 def PrintReRunMessage():
   print( '',

test_requirements.txt

@@ -7,3 +7,5 @@ psutil                >= 5.6.6
 coverage              >= 4.2
 requests
 legacy-cgi            ; python_version >= "3.13"
+# Needed for building the regex and watchdog modules.
+setuptools