fix: prevent prefixing null/empty string #3233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
obyajra
approved these changes
May 7, 2025
Owner
|
Released on https://github.com/yajra/laravel-datatables/releases/tag/v12.1.2 🚀 Thanks! |
Contributor
|
Right I forgot this one. In other places I fixed using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix to this recently merged PR: #3227
QueryDataTable::getTablePrefix() returns string or null. It causes an issue to QueryDataTable::addTablePrefix() method where in it returns a column name with a null/empty prefix (.column_name) instead of (prefix.column_name).
I added a guard clause to check if the table prefix returned by QueryDataTable::getTablePrefix() is not null/empty string before prefixing it to the column.