From ad6f7a0c2a3b573c4f10e63937aa16f03683dfdd Mon Sep 17 00:00:00 2001 From: Arjay Angeles Date: Tue, 7 Oct 2025 10:42:13 +0800 Subject: [PATCH] fix: cc footer search fix: #3256 --- src/Html/Options/Plugins/ColumnControl.php | 2 +- tests/Html/Builder/BuilderTest.php | 10 ++++------ tests/Html/Extensions/ColumnControlTest.php | 4 ++-- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/src/Html/Options/Plugins/ColumnControl.php b/src/Html/Options/Plugins/ColumnControl.php index f67bb0c..892ec95 100644 --- a/src/Html/Options/Plugins/ColumnControl.php +++ b/src/Html/Options/Plugins/ColumnControl.php @@ -70,7 +70,7 @@ public function columnControlFooter(array $content, int $target = 0): static public function columnControlFooterSearch(array $content = []): static { - $this->addColumnControl('tfoot', [empty($content) ? ['search'] : $content]); + $this->columnControlFooter(empty($content) ? ['search'] : $content); return $this; } diff --git a/tests/Html/Builder/BuilderTest.php b/tests/Html/Builder/BuilderTest.php index 32071e8..f1ea1cf 100644 --- a/tests/Html/Builder/BuilderTest.php +++ b/tests/Html/Builder/BuilderTest.php @@ -318,12 +318,10 @@ public function it_can_set_template_data(): void $builder ->setTableId('my-table') - ->setTemplateData(function (Builder $builder): array { - return [ - 'tableId' => $builder->getTableId(), - 'message' => 'Set Template Data Using Callback', - ]; - }); + ->setTemplateData(fn (Builder $builder): array => [ + 'tableId' => $builder->getTableId(), + 'message' => 'Set Template Data Using Callback', + ]); $this->assertStringContainsString( "console.log({ tableId: 'my-table', message: 'Set Template Data Using Callback' });", diff --git a/tests/Html/Extensions/ColumnControlTest.php b/tests/Html/Extensions/ColumnControlTest.php index e372e94..0384be4 100644 --- a/tests/Html/Extensions/ColumnControlTest.php +++ b/tests/Html/Extensions/ColumnControlTest.php @@ -110,7 +110,7 @@ public function it_can_add_column_control_footer_search() $this->assertInstanceOf(Builder::class, $result); $expected = [ - ['target' => 'tfoot', 'content' => [['search']]], + ['target' => 'tfoot:0', 'content' => ['search']], ]; $this->assertEquals($expected, $builder->getAttributes()['columnControl']); } @@ -125,7 +125,7 @@ public function it_can_add_column_control_footer_search_with_custom_content() $this->assertInstanceOf(Builder::class, $result); $expected = [ - ['target' => 'tfoot', 'content' => [['customSearch']]], + ['target' => 'tfoot:0', 'content' => ['customSearch']], ]; $this->assertEquals($expected, $builder->getAttributes()['columnControl']); }