Skip to content

Commit da7263f

Browse files
committed
fix: Diagnose::editOutput method param type hint error Expected type 'object'. Found 'string'
A subtle error that only occurs in vscode editor (and not when running valet); it is caused by setting the `$output` param's type hint to `string` in the docblock. But in actual fact this could be either `string` or an instance of the `ProcessOutput` class. Fixed by adding `ProcessOutput` to type hint it in the docblock param.
1 parent 98f8757 commit da7263f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

cli/Valet/Diagnose.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ protected function ignoreOutput($command) {
166166
* if the raw output isn't sufficient enough.
167167
*
168168
* @param string $command
169-
* @param string $output
169+
* @param string|ProcessOutput $output
170170
* @return string $output The edited output.
171171
*/
172172
protected function editOutput($command, $output) {

0 commit comments

Comments
 (0)