refactor: combine the code of the redundant COMPOSER_GLOBAL_PATH constant into the Diagnose command.

- Removed the redundant `COMPOSER_GLOBAL_PATH` constant because it's only used by one thing. So it doesn't need to exist.

- Changed the `Diagnose` command to get the contents of the global composer.json to use the code that was originally used to set the `COMPOSER_GLOBAL_PATH` constant. Ie. The command now directly uses the `Valet::getComposerGlobalPath` method to get the global composer path.

- Changed docblock of the `Valet::getComposerGlobalPath` method.

Author: yCodeTech

cli/Valet/Diagnose.php

@@ -38,7 +38,7 @@ public function __construct(CommandLine $cli, Filesystem $files) {
 			'php --info',
 			'php --ri curl',
 			'cmd /C curl --version',
-			'cat "' . pathFilter(COMPOSER_GLOBAL_PATH) . '/composer.json"',
+			'cat "' . pathFilter(trim(\Valet::getComposerGlobalPath())) . '/composer.json"',
 			'composer global diagnose --no-ansi 1>' . VALET_HOME_PATH . '/composer.txt',
 			'composer global outdated --format json'
 		];

cli/Valet/Valet.php

@@ -254,8 +254,7 @@ public function composerGlobalUpdate() {
 	 * composer does allow the user to change where global packages are installed.
 	 * So we need to essentially ask composer where the home directory is.
 	 *
-	 * This is used to set the `COMPOSER_GLOBAL_PATH` constant, which in turn is used
-	 * by the `Diagnose` class.
+	 * This is used by the `Diagnose` class.
 	 *
 	 * @return string The path to the global composer directory.
 	 */

cli/includes/helpers.php

@@ -24,10 +24,6 @@
 define('VALET_HOME_PATH', pathFilter($_SERVER['HOME'] . '/.config/valet'));
 define('VALET_SERVER_PATH', str_replace('\\', '/', realpath(__DIR__ . '/../../server.php')));
 define('VALET_STATIC_PREFIX', '41c270e4-5535-4daa-b23e-c269744c2f45');
-/**
- * Define the composer global path as a constant. For use with `Diagnose` class.
- */
-define('COMPOSER_GLOBAL_PATH', trim(\Valet::getComposerGlobalPath()));
 
 /**
  * Output the given text to the console.