feat: Add data extraction method to clean JSON responses from MCP, improving response handling #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…proving response handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the way responses from the MCP provider are processed and returned, focusing on extracting and presenting cleaner, more usable data from complex response structures. The changes introduce a helper method for extracting JSON or text content, and improve the metadata attached to tool results for easier debugging and traceability.
Key improvements to response handling and metadata:
Response extraction and formatting:
_extract_clean_datamethod tojaf/providers/mcp.pyfor extracting and cleaning JSON or text data from complex, nested MCP responses, handling cases withTextContentwrappers and multiple encoding layers.executemethod to use the new extraction helper, ensuring that the returneddatafield contains clean, user-friendly content instead of raw or doubly-encoded data.Metadata and diagnostics:
ToolMetadataobject in theexecutemethod to include a concise summary of the MCP response (meta info, content length, presence of structured content, and error status), improving the ability to trace and debug tool executions.