Renamed PooledSpan to TempSpan

Author: xoofx

…/LibObjectFile/Collections/PooledSpan.cs src/LibObjectFile/Collections/TempSpan.cssrc/LibObjectFile/Collections/PooledSpan.cs renamed to src/LibObjectFile/Collections/TempSpan.cs src/LibObjectFile/Collections/PooledSpan.cs renamed to src/LibObjectFile/Collections/TempSpan.cs

@@ -12,63 +12,63 @@ namespace LibObjectFile.Collections;
 /// Represents a pooled span that can be created from a stack or heap memory.
 /// </summary>
 /// <typeparam name="T">The type of the elements in the span.</typeparam>
-public readonly ref struct PooledSpan<T> where T : unmanaged
+public readonly ref struct TempSpan<T> where T : unmanaged
 {
     private readonly Span<T> _span;
     private readonly byte[]? _buffer;
 
     /// <summary>
-    /// Initializes a new instance of the <see cref="PooledSpan{T}"/> struct using a stack memory span.
+    /// Initializes a new instance of the <see cref="TempSpan{T}"/> struct using a stack memory span.
     /// </summary>
     /// <param name="span">The stack memory span.</param>
     /// <param name="size">The size of the span in bytes.</param>
-    private PooledSpan(Span<byte> span, int size)
+    private TempSpan(Span<byte> span, int size)
     {
         _span = MemoryMarshal.Cast<byte, T>(span.Slice(0, size));
         _buffer = null;
     }
 
     /// <summary>
-    /// Initializes a new instance of the <see cref="PooledSpan{T}"/> struct using a heap memory span.
+    /// Initializes a new instance of the <see cref="TempSpan{T}"/> struct using a heap memory span.
     /// </summary>
     /// <param name="buffer">The heap memory buffer.</param>
     /// <param name="size">The size of the span in bytes.</param>
-    private PooledSpan(byte[] buffer, int size)
+    private TempSpan(byte[] buffer, int size)
     {
         _span = MemoryMarshal.Cast<byte, T>(new(buffer, 0, size));
         _buffer = buffer;
     }
 
     /// <summary>
-    /// Creates a new instance of the <see cref="PooledSpan{T}"/> struct with the specified number of elements.
+    /// Creates a new instance of the <see cref="TempSpan{T}"/> struct with the specified number of elements.
     /// </summary>
     /// <param name="count">The number of elements in the span.</param>
-    /// <returns>A new instance of the <see cref="PooledSpan{T}"/> struct.</returns>
-    public static unsafe PooledSpan<T> Create(int count, out Span<T> span)
+    /// <returns>A new instance of the <see cref="TempSpan{T}"/> struct.</returns>
+    public static unsafe TempSpan<T> Create(int count, out Span<T> span)
     {
         ArgumentOutOfRangeException.ThrowIfLessThan(count, 0);
         var size = count * sizeof(T);
         var buffer = ArrayPool<byte>.Shared.Rent(size);
-        var pooledSpan = new PooledSpan<T>(buffer, size);
-        span = pooledSpan.Span;
-        return pooledSpan;
+        var tempSpan = new TempSpan<T>(buffer, size);
+        span = tempSpan.Span;
+        return tempSpan;
     }
 
     /// <summary>
-    /// Creates a new instance of the <see cref="PooledSpan{T}"/> struct with the specified number of elements, using a stack memory span if possible.
+    /// Creates a new instance of the <see cref="TempSpan{T}"/> struct with the specified number of elements, using a stack memory span if possible.
     /// </summary>
     /// <param name="stackSpan">The stack memory span.</param>
     /// <param name="count">The number of elements in the span.</param>
-    /// <returns>A new instance of the <see cref="PooledSpan{T}"/> struct.</returns>
-    public static unsafe PooledSpan<T> Create(Span<byte> stackSpan, int count, out Span<T> span)
+    /// <returns>A new instance of the <see cref="TempSpan{T}"/> struct.</returns>
+    public static unsafe TempSpan<T> Create(Span<byte> stackSpan, int count, out Span<T> span)
     {
         ArgumentOutOfRangeException.ThrowIfLessThan(count, 0);
         var size = count * sizeof(T);
         if (size <= stackSpan.Length)
         {
-            var pooledSpan = new PooledSpan<T>(stackSpan, size);
-            span = pooledSpan.Span;
-            return pooledSpan;
+            var tempSpan = new TempSpan<T>(stackSpan, size);
+            span = tempSpan.Span;
+            return tempSpan;
         }
 
         return Create(count, out span);
@@ -99,12 +99,12 @@ public void Dispose()
     /// <summary>
     /// Gets the span of elements.
     /// </summary>
-    /// <param name="pooledSpan">The pooled span to convert.</param>
-    public static implicit operator Span<T>(PooledSpan<T> pooledSpan) => pooledSpan.Span;
+    /// <param name="tempSpan">The pooled span to convert.</param>
+    public static implicit operator Span<T>(TempSpan<T> tempSpan) => tempSpan.Span;
 
     /// <summary>
     /// Gets the span of elements as a span of bytes.
     /// </summary>
-    /// <param name="pooledSpan">The pooled span to convert.</param>
-    public static implicit operator Span<byte>(PooledSpan<T> pooledSpan) => pooledSpan.AsBytes;
+    /// <param name="tempSpan">The pooled span to convert.</param>
+    public static implicit operator Span<byte>(TempSpan<T> tempSpan) => tempSpan.AsBytes;
 }

src/LibObjectFile/PE/DataDirectory/PEBoundImportDirectory.cs

@@ -79,8 +79,8 @@ public override unsafe void Read(PEImageReader reader)
 
             if (rawEntry.NumberOfModuleForwarderRefs > 0)
             {
-                using var pooledSpan = PooledSpan<RawPEBoundImportForwarderRef>.Create(rawEntry.NumberOfModuleForwarderRefs, out var spanForwarderRef);
-                var span = pooledSpan.AsBytes;
+                using var tempSpan = TempSpan<RawPEBoundImportForwarderRef>.Create(rawEntry.NumberOfModuleForwarderRefs, out var spanForwarderRef);
+                var span = tempSpan.AsBytes;
 
                 read = reader.Read(span);
                 if (read != span.Length)

src/LibObjectFile/PE/DataDirectory/PEDebugDirectory.cs

@@ -30,8 +30,8 @@ public override unsafe void Read(PEImageReader reader)
 
         // Scope the pooled span to ensure it is returned to the pool as soon as possible
         {
-            using var pooledSpan = PooledSpan<RawImageDebugDirectory>.Create(entryCount, out var entries);
-            Span<byte> span = pooledSpan;
+            using var tempSpan = TempSpan<RawImageDebugDirectory>.Create(entryCount, out var entries);
+            Span<byte> span = tempSpan;
 
             reader.Position = Position;
             int read = reader.Read(span);
@@ -132,7 +132,7 @@ internal override IEnumerable<PEObjectBase> CollectImplicitSectionDataList()
     public override void Write(PEImageWriter writer)
     {
         var entries = CollectionsMarshal.AsSpan(Entries);
-        using var pooledSpan = PooledSpan<RawImageDebugDirectory>.Create(entries.Length, out var rawEntries);
+        using var tempSpan = TempSpan<RawImageDebugDirectory>.Create(entries.Length, out var rawEntries);
 
         RawImageDebugDirectory rawEntry = default;
         for (var i = 0; i < entries.Length; i++)
@@ -160,7 +160,7 @@ public override void Write(PEImageWriter writer)
             rawEntries[i] = rawEntry;
         }
 
-        writer.Write(pooledSpan);
+        writer.Write(tempSpan);
     }
 
     protected override unsafe uint ComputeHeaderSize(PELayoutContext context)

src/LibObjectFile/PE/DataDirectory/PEDebugSectionDataRSDS.cs

@@ -46,7 +46,7 @@ public PEDebugSectionDataRSDS()
     public override unsafe void Read(PEImageReader reader)
     {
         var size = (int)Size;
-        using var pooledSpan = PooledSpan<byte>.Create(size, out var span);
+        using var tempSpan = TempSpan<byte>.Create(size, out var span);
 
         reader.Position = Position;
         var read = reader.Read(span);

src/LibObjectFile/PE/DataDirectory/PEDelayImportDirectory.cs

@@ -217,7 +217,7 @@ private unsafe uint CalculateSize()
     public override unsafe void Write(PEImageWriter writer)
     {
         var entries = CollectionsMarshal.AsSpan(Entries);
-        using var pooledSpan = PooledSpan<RawDelayLoadDescriptor>.Create(entries.Length + 1, out var rawEntries);
+        using var tempSpan = TempSpan<RawDelayLoadDescriptor>.Create(entries.Length + 1, out var rawEntries);
 
         RawDelayLoadDescriptor rawEntry = default;
         for (var i = 0; i < entries.Length; i++)
@@ -238,6 +238,6 @@ public override unsafe void Write(PEImageWriter writer)
         // Write the null entry
         rawEntries[entries.Length] = default;
 
-        writer.Write(pooledSpan.AsBytes);
+        writer.Write(tempSpan.AsBytes);
     }
 }

src/LibObjectFile/PE/DataDirectory/PEExceptionDirectory.cs

@@ -118,7 +118,7 @@ public override unsafe void Read(PEImageReader reader)
 
         reader.Position = Position;
         {
-            using var pooledSpan = PooledSpan<byte>.Create((int)size, out var span);
+            using var tempSpan = TempSpan<byte>.Create((int)size, out var span);
             int read = reader.Read(span);
             if (read != size)
             {

src/LibObjectFile/PE/DataDirectory/PEExportAddressTable.cs

@@ -38,8 +38,8 @@ public override unsafe void UpdateLayout(PELayoutContext context)
 
     public override unsafe void Read(PEImageReader reader)
     {
-        using var pooledSpan = PooledSpan<RVA>.Create(Values.Count, out var spanRva);
-        var span = pooledSpan.AsBytes;
+        using var tempSpan = TempSpan<RVA>.Create(Values.Count, out var spanRva);
+        var span = tempSpan.AsBytes;
 
         reader.Position = Position;
         int read = reader.Read(span);

src/LibObjectFile/PE/DataDirectory/PEExportNameTable.cs

@@ -34,8 +34,8 @@ public override unsafe void UpdateLayout(PELayoutContext context)
     public override unsafe void Read(PEImageReader reader)
     {
         reader.Position = Position;
-        using var pooledSpan = PooledSpan<RVA>.Create(Values.Count, out var spanRva);
-        var span = pooledSpan.AsBytes;
+        using var tempSpan = TempSpan<RVA>.Create(Values.Count, out var spanRva);
+        var span = tempSpan.AsBytes;
 
         int read = reader.Read(span);
         if (read != span.Length)

src/LibObjectFile/PE/DataDirectory/PEImportFunctionTable.cs

@@ -134,7 +134,7 @@ public void Write(PEImageWriter writer)
 
     private unsafe void Write32(PEImageWriter writer)
     {
-        using var pooledSpan = PooledSpan<RawImportFunctionEntry32>.Create(Entries.Count, out var span);
+        using var tempSpan = TempSpan<RawImportFunctionEntry32>.Create(Entries.Count, out var span);
 
         for (var i = 0; i < Entries.Count; i++)
         {
@@ -146,7 +146,7 @@ private unsafe void Write32(PEImageWriter writer)
         // Last entry is null terminator
         span[^1] = default;
 
-        writer.Write(pooledSpan);
+        writer.Write(tempSpan);
     }
 
     private unsafe void Write64(PEImageWriter writer)

src/LibObjectFile/PE/DataDirectory/PEResourceDirectoryEntry.cs

@@ -127,7 +127,7 @@ private void ReadEntry(PEImageReader reader, PEResourceDirectory directory, RawI
         {
             // Read the string
             var length = reader.ReadU16() * 2;
-            using var pooledSpan = PooledSpan<byte>.Create(length, out var span);
+            using var tempSpan = TempSpan<byte>.Create(length, out var span);
 
             int readLength = reader.Read(span);
             if (readLength != length)