Skip to content

Commit 8774714

Browse files
author
Emiliano Botti
authored
Merge pull request #90 from VeryBuy/feat/upgrade-sdk
upgrade ios sdk to 5.8.1/android sdk to 5.7.0
2 parents 87936eb + 180970b commit 8774714

File tree

4 files changed

+27
-15
lines changed

4 files changed

+27
-15
lines changed

README.md

Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,18 +59,16 @@ First, install the npm package with yarn. _Autolink_ is automatic.
5959
Inside your `AppDelegate.m`, setup the line sdk by passing the channel id obtained.
6060

6161
1. Add `platform :ios, '10.0'` in `Podfile` line:1
62-
2. Enable `use_frameworks!` in `Podfile` line:3
63-
3. Comment the code related to flipper, flipper doesn't support `use_frameworks!` !
64-
4. Modify your info.plist like it says here [Configuring the Info.plist file](https://developers.line.biz/en/docs/ios-sdk/swift/setting-up-project/#configuring-the-info-plist-file)
65-
5. Change your `AppDelegate.m` to match the following:
62+
2. Modify your info.plist like it says here [Configuring the Info.plist file](https://developers.line.biz/en/docs/ios-sdk/swift/setting-up-project/#configuring-the-info-plist-file)
63+
3. Change your `AppDelegate.m` to match the following:
6664

6765
```objc
6866
// AppDelegate.m
6967

7068
//
7169
// Import the Library
7270
//
73-
#import "RNLine-Swift.h"
71+
@import RNLine;
7472

7573
//
7674
// Setup the plugin using your CHANNEL_ID when the app finishes launching
@@ -137,7 +135,22 @@ Don't forget to add `application` function, as line's instructions indicate.
137135
```
138136

139137
3. Add `minSdkVersion = 17` in `android/build.gradle`
140-
4. In your manifest add `xmlns:tools="http://schemas.android.com/tools"` in your `manifest` tag and also `tools:replace="android:allowBackup"` in your `application` tag
138+
4. Add LineSDK as a dependency in `android/build.gradle`
139+
```gradle
140+
android {
141+
// Enable Java 1.8 support.
142+
compileOptions { // <- add this block if didn't setup
143+
sourceCompatibility JavaVersion.VERSION_1_8
144+
targetCompatibility JavaVersion.VERSION_1_8
145+
}
146+
...
147+
dependencies {
148+
...
149+
implementation 'com.linecorp.linesdk:linesdk:5.7.0' // <- add this line
150+
}
151+
}
152+
```
153+
5. In your manifest add `xmlns:tools="http://schemas.android.com/tools"` in your `manifest` tag and also `tools:replace="android:allowBackup"` in your `application` tag
141154

142155
## API
143156

RNLine.podspec

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ Pod::Spec.new do |s|
1111
s.authors = package['author']
1212
s.homepage = package['homepage']
1313
s.platform = :ios, "10.0"
14-
s.swift_version = '5.0'
14+
s.swift_version = '5.8.1'
1515

1616
s.source = { :git => "" }
1717
s.source_files = "ios/**/*.{h,m,swift}"
1818

19-
s.dependency 'React'
20-
s.dependency 'LineSDKSwift', '~> 5.0'
19+
s.dependency 'React-Core'
20+
s.dependency 'LineSDKSwift', '~> 5.8.1'
2121
end

android/build.gradle

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@ buildscript {
22
//Buildscript is evaluated before everything else so we can't use getExtOrDefault
33
def kotlin_version = rootProject.ext.has('kotlinVersion') ? rootProject.ext.get('kotlinVersion') : project.properties['ReactNativeLine_kotlinVersion']
44
ext {
5-
buildToolsVersion = "28.0.3"
5+
buildToolsVersion = "30.0.2"
66
minSdkVersion = 21
77
compileSdkVersion = 28
8-
targetSdkVersion = 28
8+
targetSdkVersion = 30
99
coroutinesAndroidVersion = "1.0.1"
1010
coroutinesCoreVersion = "1.0.1"
1111
gsonVersion = "2.8.6"
12-
linesdkVersion = "5.1.1"
12+
linesdkVersion = "5.7.0"
1313
}
1414
repositories {
1515
google()
@@ -20,7 +20,6 @@ buildscript {
2020
classpath "com.android.tools.build:gradle:3.5.1"
2121
//noinspection DifferentKotlinGradleVersion
2222
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
23-
classpath "com.linecorp:linesdk:5.1.1"
2423
}
2524
}
2625

@@ -58,7 +57,7 @@ android {
5857

5958
dependencies {
6059
implementation "com.facebook.react:react-native:+"
61-
implementation "com.linecorp:linesdk:5.1.1"
60+
implementation 'com.linecorp.linesdk:linesdk:5.7.0'
6261
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.3.50"
6362
implementation "org.jetbrains.kotlinx:kotlinx-coroutines-android:$coroutinesAndroidVersion"
6463
implementation "org.jetbrains.kotlinx:kotlinx-coroutines-core:$coroutinesCoreVersion"

android/gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ ReactNativeLine_kotlinVersion=1.3.50
22
ReactNativeLine_compileSdkVersion=28
33
ReactNativeLine_buildToolsVersion=28.0.3
44
ReactNativeLine_targetSdkVersion=28
5-
ReactNativeLine_lineSdkVersion=5.1.1
5+
ReactNativeLine_lineSdkVersion=5.7.0

0 commit comments

Comments
 (0)