Drogon package issue of ‘MICRO_SECONDS_PRE_SEC’ macro

[Casinius]

Xmake Version

3.0.5

Operating System Version and Architecture

ArtixLinux

Describe Bug

ninja build failed due to 'MICRO_SECONDS_PRE_SEC' (it is 'PRE' not 'PER', I am confident that the author must spell it wrong

error as above

Expected Behavior

Install Drogon intactly

Project Configuration

add_rules("mode.debug", "mode.release")
add_rules("plugin.compile_commands.autoupdate", {outputdir = "."})

add_requires("drogon v1.9.11", {
    configs = {
        spdlog = true,
        cpp20=true
    }
})
add_requires("spdlog","nlohmann_json")
add_languages("c++23")
target("name")
    set_kind("binary")
    add_files("src/*.cpp")
    add_packages("drogon","spdlog","nlohmann_json")

Additional Information and Error Logs

FAILED: [code=1] CMakeFiles/drogon.dir/lib/src/HttpResponseImpl.cc.o 
/usr/bin/c++ -DFMT_HEADER_ONLY -DFMT_HEADER_ONLY=1 -DSPDLOG_FMT_EXTERNAL -DSPDLOG_FWRITE_UNLOCKED -DTRANTOR_SPDLOG_SUPPORT -DUSE_BROTLI -DUSE_OSSP_UUID=0 -I/home/cyan/.xmake/cache/packages/2512/d/drogon/v1.9.11/source/lib/inc -I/home/cyan/.xmake/cache/packages/2512/d/drogon/v1.9.11/source/build_6e23f81d/lib/inc -I/home/cyan/.xmake/cache/packages/2512/d/drogon/v1.9.11/source/orm_lib/inc -I/home/cyan/.xmake/cache/packages/2512/d/drogon/v1.9.11/source/nosql_lib/redis/inc -I/home/cyan/.xmake/cache/packages/2512/d/drogon/v1.9.11/source/build_6e23f81d -I/home/cyan/.xmake/cache/packages/2512/d/drogon/v1.9.11/source/build_6e23f81d/exports -isystem /home/cyan/.xmake/packages/t/trantor/v1.5.25/ad12aaad5e054cdba23cee7d31744171/include -isystem /home/cyan/.xmake/packages/s/spdlog/v1.16.0/8348853325c94dd0a62f96feb47eb49a/include -isystem /home/cyan/.xmake/packages/f/fmt/12.1.0/8a24306c357441a095c4e7e3408475be/include -isystem /usr/include/uuid -O3 -DNDEBUG -std=c++20 -fPIC -MD -MT CMakeFiles/drogon.dir/lib/src/HttpResponseImpl.cc.o -MF CMakeFiles/drogon.dir/lib/src/HttpResponseImpl.cc.o.d -fmodules-ts -fmodule-mapper=CMakeFiles/drogon.dir/lib/src/HttpResponseImpl.cc.o.modmap -MD -fdeps-format=p1689r5 -x c++ -o CMakeFiles/drogon.dir/lib/src/HttpResponseImpl.cc.o -c /home/cyan/.xmake/cache/packages/2512/d/drogon/v1.9.11/source/lib/src/HttpResponseImpl.cc
/home/cyan/.xmake/cache/packages/2512/d/drogon/v1.9.11/source/lib/src/HttpResponseImpl.cc: In member function ‘std::shared_ptr<trantor::MsgBuffer> drogon::HttpResponseImpl::renderToBuffer()’:
/home/cyan/.xmake/cache/packages/2512/d/drogon/v1.9.11/source/lib/src/HttpResponseImpl.cc:657:54: error: ‘MICRO_SECONDS_PRE_SEC’ was not declared in this scope
  657 |                     ((now.microSecondsSinceEpoch() / MICRO_SECONDS_PRE_SEC) !=
      |                                                      ^~~~~~~~~~~~~~~~~~~~~
[108/245] Building CXX object CMakeFiles/drogon.dir/lib/src/HttpViewData.cc.o
[109/245] Building CXX object CMakeFiles/drogon.dir/lib/src/JsonConfigAdapter.cc.o
[110/245] Building CXX object CMakeFiles/drogon.dir/lib/src/HttpRequestParser.cc.o
[111/245] Building CXX object CMakeFiles/drogon.dir/lib/src/HttpUtils.cc.o
/home/cyan/.xmake/cache/packages/2512/d/drogon/v1.9.11/source/lib/src/HttpUtils.cc:62:10: warning: ‘drogon::CT_APPLICATION_X_JAVASCRIPT’ is deprecated: use CT_TEXT_JAVASCRIPT [-Wdeprecated-declarations]
   62 |         {CT_APPLICATION_X_JAVASCRIPT,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/cyan/.xmake/cache/packages/2512/d/drogon/v1.9.11/source/lib/src/HttpUtils.h:18,
                 from /home/cyan/.xmake/cache/packages/2512/d/drogon/v1.9.11/source/lib/src/HttpUtils.cc:15:
/home/cyan/.xmake/cache/packages/2512/d/drogon/v1.9.11/source/lib/inc/drogon/HttpTypes.h:106:5: note: declared here
  106 |     CT_APPLICATION_X_JAVASCRIPT [[deprecated("use CT_TEXT_JAVASCRIPT")]],
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/cyan/.xmake/cache/packages/2512/d/drogon/v1.9.11/source/lib/src/HttpUtils.cc: In lambda function:
/home/cyan/.xmake/cache/packages/2512/d/drogon/v1.9.11/source/lib/src/HttpUtils.cc:733:23: warning: ‘drogon::CT_APPLICATION_X_JAVASCRIPT’ is deprecated: use CT_TEXT_JAVASCRIPT [-Wdeprecated-declarations]
  733 |         extensionMap_[CT_APPLICATION_X_JAVASCRIPT] =
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/cyan/.xmake/cache/packages/2512/d/drogon/v1.9.11/source/lib/inc/drogon/HttpTypes.h:106:5: note: declared here
  106 |     CT_APPLICATION_X_JAVASCRIPT [[deprecated("use CT_TEXT_JAVASCRIPT")]],
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
[112/245] Building CXX object CMakeFiles/drogon.dir/lib/src/IntranetIpFilter.cc.o
[113/245] Building CXX object CMakeFiles/drogon.dir/lib/src/LocalHostFilter.cc.o
[114/245] Building CXX object CMakeFiles/drogon.dir/lib/src/ListenerManager.cc.o
[115/245] Building CXX object CMakeFiles/drogon.dir/lib/src/HttpControllersRouter.cc.o
[116/245] Building CXX object CMakeFiles/drogon.dir/lib/src/HttpServer.cc.o
ninja: build stopped: subcommand failed.

[Casinius]

很难绷得住，而且-D定义macro也无法正确编译通过，我只能用replace大法替换为1000000
修复如下
io.replace("lib/src/HttpResponseImpl.cc", [[MICRO_SECONDS_PRE_SEC]], [[1000000]], {plain = true})
io.replace("lib/src/Utilities.cc", [[MICRO_SECONDS_PRE_SEC]], [[1000000]], {plain = true})

[Issues-translate-bot]

Bot detected the issue body's language is not English, translate it automatically.

---

It’s hard to hold on, and the macro defined by -D cannot be compiled correctly. I can only use the replace method to replace it with 1000000.
The fix is as follows
io.replace("lib/src/HttpResponseImpl.cc", [[MICRO_SECONDS_PRE_SEC]], [[1000000]], {plain = true})
io.replace("lib/src/Utilities.cc", [[MICRO_SECONDS_PRE_SEC]], [[1000000]], {plain = true})

[star-hengxing]

trantor >=v1.5.25 -> MICRO_SECONDS_PER_SEC an-tao/trantor#378
trantor <v1.5.25 & drogon -> MICRO_SECONDS_PRE_SEC

I think we only can limit trantor version to fix the issue, because directly patch source files maybe break old drogon version, any idea?