Skip to content

Commit 27984dd

Browse files
Remove usage of deprecated GUtil; move to own PropertiesUtil class
1 parent b12c31f commit 27984dd

File tree

3 files changed

+53
-6
lines changed

3 files changed

+53
-6
lines changed
Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
package eu.xenit.gradle.alfrescosdk.internal;
2+
3+
import java.io.File;
4+
import java.io.FileInputStream;
5+
import java.io.FileOutputStream;
6+
import java.io.IOException;
7+
import java.io.InputStream;
8+
import java.util.Properties;
9+
import org.gradle.api.UncheckedIOException;
10+
11+
public final class PropertiesUtil {
12+
private PropertiesUtil() {
13+
throw new UnsupportedOperationException("This utility class can not be instantiated");
14+
}
15+
16+
public static Properties loadProperties(File propertyFile) {
17+
try {
18+
try(FileInputStream inputStream = new FileInputStream(propertyFile)) {
19+
return loadProperties(inputStream);
20+
}
21+
} catch (IOException e) {
22+
throw new UncheckedIOException(e);
23+
}
24+
}
25+
26+
private static Properties loadProperties(InputStream inputStream) {
27+
Properties properties = new Properties();
28+
try {
29+
properties.load(inputStream);
30+
} catch (IOException e) {
31+
throw new UncheckedIOException(e);
32+
}
33+
return properties;
34+
}
35+
36+
public static void saveProperties(Properties properties, File propertyFile) {
37+
try {
38+
try (FileOutputStream propertiesFileOutputStream = new FileOutputStream(propertyFile)) {
39+
properties.store(propertiesFileOutputStream, null);
40+
}
41+
} catch (IOException e) {
42+
throw new UncheckedIOException(e);
43+
}
44+
}
45+
46+
}

src/main/java/eu/xenit/gradle/alfrescosdk/internal/tasks/DefaultAmpSourceSetConfiguration.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package eu.xenit.gradle.alfrescosdk.internal.tasks;
22

3+
import eu.xenit.gradle.alfrescosdk.internal.PropertiesUtil;
34
import eu.xenit.gradle.alfrescosdk.tasks.AmpSourceSet;
45
import eu.xenit.gradle.alfrescosdk.tasks.AmpSourceSetConfiguration;
56
import java.io.File;
@@ -13,7 +14,6 @@
1314
import org.gradle.api.provider.Property;
1415
import org.gradle.api.provider.Provider;
1516
import org.gradle.api.tasks.SourceSet;
16-
import org.gradle.util.GUtil;
1717

1818
public class DefaultAmpSourceSetConfiguration implements AmpSourceSetConfiguration {
1919

@@ -60,7 +60,7 @@ public AmpSourceSetConfiguration module(String moduleProperties) {
6060
@Override
6161
public AmpSourceSetConfiguration module(File moduleProperties) {
6262
return module(properties -> {
63-
properties.putAll(GUtil.loadProperties(moduleProperties));
63+
properties.putAll(PropertiesUtil.loadProperties(moduleProperties));
6464
});
6565
}
6666

@@ -87,7 +87,7 @@ public AmpSourceSetConfiguration fileMapping(String fileMappingProperties) {
8787
@Override
8888
public AmpSourceSetConfiguration fileMapping(File fileMappingProperties) {
8989
return fileMapping(properties -> {
90-
properties.putAll(GUtil.loadProperties(fileMappingProperties));
90+
properties.putAll(PropertiesUtil.loadProperties(fileMappingProperties));
9191
});
9292
}
9393

@@ -125,4 +125,5 @@ public SourceDirectorySet getConfig() {
125125
public SourceDirectorySet getWeb() {
126126
return web;
127127
}
128+
128129
}

src/test/java/eu/xenit/gradle/alfrescosdk/AmpBasePluginTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import static org.junit.Assert.assertNotNull;
66
import static org.junit.Assert.assertTrue;
77

8+
import eu.xenit.gradle.alfrescosdk.internal.PropertiesUtil;
89
import eu.xenit.gradle.alfrescosdk.tasks.Amp;
910
import eu.xenit.gradle.alfrescosdk.tasks.AmpSourceSetConfiguration;
1011
import java.io.File;
@@ -19,7 +20,6 @@
1920
import org.gradle.api.tasks.SourceSet;
2021
import org.gradle.api.tasks.WriteProperties;
2122
import org.gradle.testfixtures.ProjectBuilder;
22-
import org.gradle.util.GUtil;
2323
import org.junit.Rule;
2424
import org.junit.Test;
2525
import org.junit.rules.TemporaryFolder;
@@ -95,12 +95,12 @@ public void autoConfigureSourceSet() throws IOException {
9595
Properties moduleProperties = new Properties();
9696
moduleProperties.setProperty("module.id", "test-amp");
9797
moduleProperties.setProperty("module.version", "1.0.0");
98-
GUtil.saveProperties(moduleProperties, modulePropertiesFile);
98+
PropertiesUtil.saveProperties(moduleProperties, modulePropertiesFile);
9999

100100
File fileMappingPropertiesFile = ampFolder.resolve("file-mapping.properties").toFile();
101101
Properties fileMappingProperties = new Properties();
102102
fileMappingProperties.setProperty("/override", "/");
103-
GUtil.saveProperties(fileMappingProperties, fileMappingPropertiesFile);
103+
PropertiesUtil.saveProperties(fileMappingProperties, fileMappingPropertiesFile);
104104

105105
DefaultProject project = getDefaultProject();
106106
// Java plugin is required for the jar task

0 commit comments

Comments
 (0)