Multiple MANIFEST.MF in alfrescoWar artifact

[todorinskiz]

Caused by:

alfresco-docker-gradle-plugin/src/main/java/eu/xenit/gradle/docker/alfresco/tasks/MergeWarsTask.java

Line 27 in 01e4a68

childWars.setDuplicatesStrategy(DuplicatesStrategy.INCLUDE);

Any vanilla project should be able to reproduce it.

Linked issues: #229 #220

[todorinskiz]

I managed to simplify my use case to:

task buildCustomWar(type: War) {
    dependsOn project.tasks.alfrescoWar
    afterEvaluate {
        def outputDir = mkdir("${project.buildDir}/dist/")
        archiveFileName = "${artifact}-${flavor}-${project.version}.war"
        destinationDirectory = outputDir

        manifest {
            attributes("Implementation-Title":"alfresco")
            attributes("Implementation-Version":"${project.version}")
            attributes("Implementation-Vendor-Id":"eu.xenit.${project.flavor}.war")
        }

        from(zipTree(project.tasks.alfrescoWar.getOutputs().files.singleFile))
    }
}

How I believe this should be consumed is:

alfrescoWar {
    manifest {
        attributes("Implementation-Title":"alfresco")
        attributes("Implementation-Version":"${project.version}")
        attributes("Implementation-Vendor-Id":"eu.xenit.${project.flavor}.war")
    }
}

But this is not possible since neither MergeWarsTask or AbstractWarEnrichmentTask provide option to filter/manipulate the copy specs.

Maybe that's by design? Still, it's much more efficient to manipulate sources on-the-fly rather than waiting for the artifact and then unzip + copy to new artifact.

[vierbergenlars]

We can not remove DuplicatesStrategy.INCLUDE, because that is necessary for AMPs that overwrite core Alfresco files to work (for example, our hotfix amps).

You should be able to use the manifest function in alfrescoWar, but I don't know if it runs before or after the merging of WAR files.

alfrescoWar {
  manifest {
    // ...
  }
}

[todorinskiz]

possibly related gradle/gradle#17236