Skip to content

Commit e37870b

Browse files
Merge pull request #296 from xenit-eu/unignore-tests
Revert "Ignore test awaiting bugfix gradle-docker-plugin dependency"
2 parents 8f7c68a + 435f899 commit e37870b

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

src/integrationTest/java/eu/xenit/gradle/testrunner/Reproductions.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
import org.gradle.testkit.runner.TaskOutcome;
1616
import org.gradle.util.GradleVersion;
1717
import org.hamcrest.Matchers;
18-
import org.junit.Ignore;
1918
import org.junit.Test;
2019

2120
/**
@@ -132,7 +131,6 @@ public void testIssue104() throws IOException {
132131
}
133132

134133
@Test
135-
@Ignore("Waiting for a fix for https://github.com/bmuschko/gradle-docker-plugin/issues/1158")
136134
public void testIssue107() throws IOException {
137135
testProjectFolder(REPRODUCTIONS.resolve("issue-107"), ":functionalTest");
138136
}

src/integrationTest/reproductions/issue-107/build.gradle

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,14 @@ import com.bmuschko.gradle.docker.tasks.image.*
3535

3636
task saveDockerImage(type: DockerSaveImage) {
3737
dependsOn(buildDockerImage)
38-
image = buildDockerImage.imageId
38+
images.add(buildDockerImage.imageId)
3939
destFile = project.layout.buildDirectory.file("builtImage.tar")
4040
}
4141

4242
task saveBaseDockerImage(type: DockerSaveImage) {
43-
image = dockerAlfresco.baseImage
43+
images.add(dockerAlfresco.baseImage)
4444
destFile = project.layout.buildDirectory.file("originalImage.tar")
45+
mustRunAfter(buildDockerImage) // because the build pulls the base image if it does not exist on disk yet
4546
}
4647
import java.util.stream.Collectors
4748
import java.util.stream.Stream

0 commit comments

Comments
 (0)