improved code coverage (#1)

* test: improved code coverage

* fix: improved code coverage

* feat: exclude .phpstorm.meta.php

Author: wyster

.phpstorm.meta.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace PHPSTORM_META
+{
+    $STATIC_METHOD_TYPES = [
+        \Test\_generated\UnitTesterActions::grabService('') => [
+            "" == "@",
+        ],
+    ];
+}

grumphp.yml

@@ -41,7 +41,7 @@ parameters:
           - test
       - scopes: []
     phpstan:
-      ignore_patterns: [src/Migrations, c3.php]
+      ignore_patterns: [src/Migrations, c3.php, .phpstorm.meta.php]
     phplint: ~
     phpversion:
       project: '7.4'

src/Repository/MakeRepository.php

@@ -17,6 +17,8 @@ public function __construct(ManagerRegistry $registry)
     }
 
     /**
+     * @param int $id
+     * @return Make
      * @throws RowNotFoundException
      */
     public function findById(int $id): Make

src/Service/SearchService.php

@@ -35,7 +35,7 @@ public function search(Make $make, VehicleType $type): array
         return $results;
     }
 
-    private function createLog(Make $make, VehicleType $type, int $resultCount, StopwatchEvent $stopwatchEvent): void
+    private function createLog(Make $make, VehicleType $type, int $resultsCount, StopwatchEvent $stopwatchEvent): void
     {
         $ip = '';
         $userAgent = '';
@@ -46,7 +46,7 @@ private function createLog(Make $make, VehicleType $type, int $resultCount, Stop
 
         $log = new SearchLog();
         $log->setIpAddress($ip);
-        $log->setFoundModels($resultCount);
+        $log->setFoundModels($resultsCount);
         $log->setUserAgent($userAgent);
         $log->setMakeAbbr($make->getCode());
         $log->setVehicleType($type->getCode());

tests/functional/ModelCest.php

@@ -16,4 +16,18 @@ public function tryToTest(FunctionalTester $I): void
         $content = $I->grabPageSource();
         $I->assertStringContainsString('[{"id":1,"description":"LESABRE"}]', $content);
     }
+
+    public function tryToTestEmptyModel(FunctionalTester $I): void
+    {
+        $I->haveInDatabase('vehicle_type', ['id' => 1, 'description' => 'Automobile', 'code' => 'V']);
+        $I->haveInDatabase('make', ['id' => 2, 'type_id' => 1, 'code' => 'BUIC', 'description' => 'Buic']);
+        $I->sendAjaxGetRequest('/models/1/2');
+        $I->canSeeResponseCodeIs(404);
+    }
+
+    public function tryToTestNotFound(FunctionalTester $I): void
+    {
+        $I->sendAjaxGetRequest('/models/1/1');
+        $I->canSeeResponseCodeIs(404);
+    }
 }

tests/unit.suite.yml

@@ -7,4 +7,14 @@ modules:
     enabled:
         - Asserts
         - \Test\Helper\Unit
-    step_decorators: ~        
+        - Symfony:
+            app_path: 'src'
+            environment: 'test'
+        - Doctrine2:
+            depends: Symfony
+            cleanup: true
+        - Db:
+            dsn: 'mysql:host=mysql;dbname=example'
+            user: 'dev'
+            password: 'dev'
+    step_decorators: ~

tests/unit/Entity/MakeTest.php

@@ -0,0 +1,32 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Test\Entity;
+
+use App\Entity\Make;
+use App\Entity\VehicleType;
+use Codeception\Test\Unit;
+use Doctrine\ORM\EntityManagerInterface;
+use Test\UnitTester;
+
+class MakeTest extends Unit
+{
+    protected UnitTester $tester;
+
+    public function testSetters(): void
+    {
+        $em = $this->tester->grabService(EntityManagerInterface::class);
+        $vehicleType = new VehicleType();
+        $vehicleType->setCode('V');
+        $vehicleType->setDescription('Automobile');
+        $em->persist($vehicleType);
+
+        $make = new Make();
+        $make->setType($vehicleType);
+        $make->setDescription('Buic');
+        $make->setCode('BUIC');
+        $em->persist($make);
+        $em->flush();
+    }
+}

tests/unit/Entity/ModelTest.php

@@ -0,0 +1,45 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Test\Entity;
+
+use App\Entity\Make;
+use App\Entity\Model;
+use App\Entity\VehicleType;
+use Codeception\Test\Unit;
+use Doctrine\ORM\EntityManagerInterface;
+use Test\UnitTester;
+
+class ModelTest extends Unit
+{
+    protected UnitTester $tester;
+
+    public function testSetters(): void
+    {
+        $em = $this->tester->grabService(EntityManagerInterface::class);
+        $vehicleType = new VehicleType();
+        $vehicleType->setCode('V');
+        $vehicleType->setDescription('Automobile');
+        $em->persist($vehicleType);
+
+        $make = new Make();
+        $make->setType($vehicleType);
+        $make->setDescription('Buic');
+        $make->setCode('BUIC');
+        $em->persist($make);
+
+        $model = new Model();
+        $model->setType($vehicleType);
+        $model->setMake($make);
+        $model->setDescription('RIVIERA');
+        $em->persist($model);
+
+        $em->flush();
+
+        $this->assertIsInt($model->getId());
+        $this->assertInstanceOf(VehicleType::class, $model->getType());
+        $this->assertInstanceOf(Make::class, $model->getMake());
+        $this->assertSame('RIVIERA', $model->getDescription());
+    }
+}

tests/unit/Entity/SearchLogTest.php

@@ -0,0 +1,39 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Test\Entity;
+
+use App\Entity\SearchLog;
+use Codeception\Test\Unit;
+use Doctrine\ORM\EntityManagerInterface;
+use Laminas\Hydrator\ClassMethodsHydrator;
+use Test\UnitTester;
+
+class SearchLogTest extends Unit
+{
+    protected UnitTester $tester;
+
+    private array $logData = [
+        'vehicle_type' => 'V',
+        'make_abbr' => 'TESL',
+        'found_models' => 500,
+        'ip_address' => '127.0.0.1',
+        'user_agent' => 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.169 Safari/537.36',
+        'request_time' => 100.0
+    ];
+
+    public function testSettersAndGetters(): void
+    {
+        $em = $this->tester->grabService(EntityManagerInterface::class);
+        $searchLog = new SearchLog();
+        $hydrator = new ClassMethodsHydrator();
+        $hydrator->hydrate($this->logData, $searchLog);
+        $em->persist($searchLog);
+        $em->flush();
+
+        $data = $hydrator->extract($searchLog);
+        unset($data['id']);
+        $this->assertSame($this->logData, $data);
+    }
+}

tests/unit/Entity/VehicleTypeTest.php

@@ -0,0 +1,34 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Test\Entity;
+
+use App\Entity\VehicleType;
+use Codeception\Test\Unit;
+use Doctrine\ORM\EntityManagerInterface;
+use Laminas\Hydrator\ClassMethodsHydrator;
+use Test\UnitTester;
+
+class VehicleTypeTest extends Unit
+{
+    protected UnitTester $tester;
+
+    private array $vehicleTypeData = [
+        'code' => 'V',
+        'description' => 'Automobile'
+    ];
+
+    public function testSettersAndGetters(): void
+    {
+        $em = $this->tester->grabService(EntityManagerInterface::class);
+        $searchLog = new VehicleType();
+        $hydrator = new ClassMethodsHydrator();
+        $hydrator->hydrate($this->vehicleTypeData, $searchLog);
+        $em->persist($searchLog);
+        $em->flush();
+
+        $this->assertEquals($this->vehicleTypeData['code'], $searchLog->getCode());
+        $this->assertEquals($this->vehicleTypeData['description'], $searchLog->getDescription());
+    }
+}