Skip to content

Commit f13c772

Browse files
committed
fix: exec with cmd
1 parent 1f393a5 commit f13c772

File tree

3 files changed

+15
-7
lines changed

3 files changed

+15
-7
lines changed

route/exec.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,11 @@ import (
1818
func (server *Server) handleExecRedirect(c *gin.Context) {
1919
containerID := c.Param("cid")
2020
execID := server.setContainerID(containerID)
21-
c.Redirect(302, "/exec/"+execID)
21+
if query := c.Request.URL.RawQuery; query != "" {
22+
c.Redirect(302, "/exec/"+execID+"?"+c.Request.URL.RawQuery)
23+
} else {
24+
c.Redirect(302, "/exec/"+execID)
25+
}
2226
}
2327

2428
func (server *Server) handleExec(c *gin.Context, counter *counter) {
@@ -104,7 +108,7 @@ func (server *Server) processTTY(ctx context.Context, execID string, timeoutCanc
104108
if err != nil {
105109
return err
106110
}
107-
log.Debugf("exec container: %s, params: %s", container.ID[:7], arguments)
111+
log.Debugf("exec container: %s, params: [%s]", container.ID[:7], arguments)
108112

109113
q, err := parseQuery(strings.TrimSpace(arguments))
110114
if err != nil {

route/handler.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,15 +102,15 @@ func (server *Server) handleRestartContainer(c *gin.Context) {
102102
server.handleContainerActions(c, "restart")
103103
}
104104

105-
func (server *Server) makeTitleBuff(c types.Container, readonly ...bool) ([]byte, error) {
106-
location := "127.0.0.1"
105+
func (server *Server) makeTitleBuff(c types.Container, extra ...string) ([]byte, error) {
106+
location := "localhost"
107107
if c.LocServer != "" {
108108
location = c.LocServer
109109
}
110110

111111
cName := c.Name
112-
if len(readonly) == 1 && readonly[0] {
113-
cName = "[READONLY] " + c.Name
112+
if len(extra) != 0 {
113+
cName = extra[0] + " " + c.Name
114114
}
115115

116116
titleVars := server.titleVariables(

route/share.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,11 @@ func (server *Server) processShare(c *gin.Context, execID string, masterTTY *typ
3131
}
3232

3333
cInfo := server.containerCli.GetInfo(ctx, containerID)
34-
titleBuf, err := server.makeTitleBuff(cInfo, !server.options.Collaborate)
34+
var titleExtra = "[READONLY]"
35+
if server.options.Collaborate {
36+
titleExtra = "[SLAVE]"
37+
}
38+
titleBuf, err := server.makeTitleBuff(cInfo, titleExtra)
3539
if err != nil {
3640
e := fmt.Sprintf("failed to fill window title template: %s", err)
3741
conn.WriteMessage(websocket.CloseMessage, []byte(e))

0 commit comments

Comments
 (0)