Fix incorrect start_date on exported subscriptions #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exporting subscriptions that were previously imported is returning incorrect values for the `start_date` column, with the returned value being the date the subscriptions were imported rather than the start date of the subscription. This basic PR changes the call to `WC_Subscription::get_date()` to use `'start'` as the `$date_type` parameter instead of `'date_created'`, which doesn't even appear to be a valid `$date_type`. Does this perhaps need to fall back to `'date_created'` if the value of `'start'` is empty?
Author
|
See https://docs.woocommerce.com/document/subscriptions/develop/functions/#section-3 for docs on |
sun
approved these changes
May 5, 2023
sun
left a comment
sun
left a comment
There was a problem hiding this comment.
👌 This is correct. A subscription may not necessarily start immediately when it is created.
|
The build errors are not related to this change. |
|
The change is still correct and necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exporting subscriptions that were previously imported is returning incorrect values for the
start_datecolumn, with the returned value being the date the subscriptions were imported rather than the start date of the subscription.This basic PR changes the call to
WC_Subscription::get_date()to use'start'as the$date_typeparameter instead of'date_created', which doesn't even appear to be a valid$date_type.Does this perhaps need to fall back to
'date_created'if the value of'start'is empty?