test(transactions): Add formatter + fix tests

Author: taylorjdawson

dist/web3data.min.js

@@ -3,7 +3,14 @@ const {
   ERROR_MESSAGE_TRANSACTION_NO_HASH: NO_HASH
 } = require('./constants')
 
-const {is, get, onFulfilled, onError, throwIf} = require('./utils')
+const {
+  is,
+  get,
+  onFulfilled,
+  onError,
+  throwIf,
+  recordsFormatter
+} = require('./utils')
 
 class Transaction {
   constructor(web3data) {
@@ -14,7 +21,7 @@ class Transaction {
     return get(this.web3data, {
       endpoint: ENDPOINT,
       filterOptions
-    }).then(onFulfilled, onError)
+    }).then(onFulfilled.bind({formatter: recordsFormatter}), onError)
   }
 
   getTransaction(hash, filterOptions) {

src/transaction.js

@@ -52,14 +52,14 @@ const returnsTxnObject = async (t, { method, params = {} }) => {
 returnsTxnObject.title = (providedTitle = '', input) => `Successfully calls ${input.method} and returns valid txn object`
 
 const returnsTxnObjects = async (t, { method }) => {
-    const { records: transactions } = await t.context.web3data.transaction[method]()
+    const transactions = await t.context.web3data.transaction[method]()
     t.true(transactions[0].hasProp('hash'))
     t.true(transactions.length > 0)
 }
 returnsTxnObjects.title = (providedTitle = '', input) => `Successfully calls ${input.method} and returns array of valid txn objects`
 
 const returnsPendingTxnObjects = async (t, { method }) => {
-    const { records: [pendingTxn]} = await t.context.web3data.transaction[method]()
+    const [pendingTxn] = await t.context.web3data.transaction[method]()
 
     t.is(pendingTxn.statusResult.name, 'pending')
 }
@@ -73,11 +73,11 @@ test([returnsTxnObjects, returnsPendingTxnObjects], {method:'getPendingTransacti
 
 /*********** Test getTransactions() ***********/
 test('Successfully calls getTransactions', async t => {
-    const {records: [txn]} = await t.context.web3data.transaction.getTransactions()
+    const [txn] = await t.context.web3data.transaction.getTransactions()
     t.true(txn.hasProp('hash'))
 })
 test('Successfully calls getTransactions - with filters', async t => {
-    const {records: [pendingTxn]} = await t.context.web3data.transaction.getTransactions({status: 'pending'})
+    const [pendingTxn] = await t.context.web3data.transaction.getTransactions({status: 'pending'})
     t.true(pendingTxn.hasProp('statusResult'))
     t.true(pendingTxn.statusResult.hasProp('name'))
     t.is(pendingTxn.statusResult.name, 'pending')
@@ -96,7 +96,7 @@ test('Successfully calls getTransaction - with filters', async t => {
 
 /*********** Test getPendingTransactions() ***********/
 test('Successfully calls getPendingTransactions', async t => {
-    const {records: [pendingTxn]} = await t.context.web3data.transaction.getPendingTransactions()
+    const [pendingTxn] = await t.context.web3data.transaction.getPendingTransactions()
     t.true(pendingTxn.hasProp('statusResult'))
     t.true(pendingTxn.statusResult.hasProp('name'))
     t.is(pendingTxn.statusResult.name, 'pending')

test/transaction.test.js

@@ -107,7 +107,7 @@ test('web3data.eth successfully calls method getTransactions', async t => {
 })
 
 test('web3data.eth successfully calls method getPendingTransactions', async t => {
-    const { records: pendTxns } = await t.context.web3data.eth.getPendingTransactions()
+    const pendTxns  = await t.context.web3data.eth.getPendingTransactions()
     t.true(pendTxns.length > 0)
 })