Fix nps for windows

- Remove trailing comma
- cleanup the mess of direct node_module access
- db section isn't working because of typeorm

Author: dweber019

package-scripts.js

@@ -1,3 +1,7 @@
+/**
+ * Windows: Please do not use trailing comma as windows will fail with token error
+ */
+
 const { series, crossEnv, concurrent, rimraf, runInNewWindow } = require('nps-utils');
 
 module.exports = {
@@ -17,8 +21,8 @@ module.exports = {
         serve: {
             script: series(
                 'nps banner.serve',
-                '\"./node_modules/.bin/nodemon\" --watch src --watch \".env\"',
-            ),
+                'nodemon --watch src --watch .env'
+            )
         },
         /**
          * Setup's the development environment and the database
@@ -28,7 +32,7 @@ module.exports = {
                 'yarn install',
                 'nps db.migrate',
                 'nps db.seed'
-            ),
+            )
         },
         /**
          * Builds the app into the dist directory
@@ -39,8 +43,8 @@ module.exports = {
                 'nps lint',
                 'nps clean.dist',
                 'nps transpile',
-                'nps copy',
-            ),
+                'nps copy'
+            )
         },
         /**
          * Database scripts
@@ -50,29 +54,29 @@ module.exports = {
                 script: series(
                     'nps banner.migrate',
                     'nps db.config',
-                    runFast('\"./node_modules/.bin/typeorm\" migrations:run'),
-                ),
+                    runFast('\"./node_modules/.bin/typeorm\" migrations:run')
+                )
             },
             revert: {
                 script: series(
                     'nps banner.revert',
                     'nps db.config',
-                    runFast('\"./node_modules/.bin/typeorm\" migrations:revert'),
-                ),
+                    runFast('\"./node_modules/.bin/typeorm\" migrations:revert')
+                )
             },
             seed: {
                 script: series(
                     'nps banner.seed',
                     'nps db.config',
-                    runFast('\"./src/lib/seeds/\"'),
-                ),
+                    runFast('./src/lib/seeds/')
+                )
             },
             config: {
-                script: runFast('\"./src/lib/ormconfig.ts\"'),
+                script: runFast('./src/lib/ormconfig.ts')
             },
             drop: {
-                script: runFast('\"./node_modules/.bin/typeorm\" schema:drop'),
-            },
+                script: runFast('\"./node_modules/.bin/typeorm\" schema:drop')
+            }
         },
         /**
          * These run various kinds of tests. Default is unit.
@@ -84,54 +88,54 @@ module.exports = {
                     script: series(
                         'nps banner.test',
                         'nps test.unit.pretest',
-                        'nps test.unit.run',
-                    ),
+                        'nps test.unit.run'
+                    )
                 },
                 pretest: {
-                    script: '\"./node_modules/.bin/tslint\" -c \"./tslint.json\" -t stylish \"./test/unit/**/*.ts\"'
+                    script: 'tslint -c ./tslint.json -t stylish ./test/unit/**/*.ts'
                 },
                 run: {
-                    script: '\"./node_modules/.bin/cross-env\" NODE_ENV=test \"./node_modules/.bin/jest\" --testPathPattern=unit'
+                    script: 'cross-env NODE_ENV=test jest --testPathPattern=unit'
                 },
                 verbose: {
                     script: 'nps "test --verbose"'
                 },
                 coverage: {
                     script: 'nps "test --coverage"'
-                },
+                }
             },
             e2e: {
                 default: {
                     script: series(
                         'nps banner.test',
                         'nps test.e2e.pretest',
                         runInNewWindow(series('nps build', 'nps start')),
-                        'nps test.e2e.run',
-                    ),
+                        'nps test.e2e.run'
+                    )
                 },
                 pretest: {
-                    script: '\"./node_modules/.bin/tslint\" -c \"./tslint.json\" -t stylish \"./test/e2e/**/*.ts\"'
+                    script: 'tslint -c ./tslint.json -t stylish ./test/e2e/**/*.ts'
                 },
                 verbose: {
                     script: 'nps "test.e2e --verbose"'
                 },
                 run: series(
                     `wait-on --timeout 120000 http-get://localhost:3000/api/info`,
-                    '\"./node_modules/.bin/cross-env\" NODE_ENV=test \"./node_modules/.bin/jest\" --testPathPattern=e2e -i',
-                ),
+                    'cross-env NODE_ENV=test jest --testPathPattern=e2e -i'
+                )
             }
         },
         /**
          * Runs TSLint over your project
          */
         lint: {
-            script: `\"./node_modules/.bin/tslint\" -c \"./tslint.json\" -p tsconfig.json \"src/**/*.ts\" --format stylish`
+            script: `tslint -c ./tslint.json -p tsconfig.json src/**/*.ts --format stylish`
         },
         /**
          * Transpile your app into javascript
          */
         transpile: {
-            script: `\"./node_modules/.bin/tsc\"`
+            script: `tsc`
         },
         /**
          * Clean files and folders
@@ -140,11 +144,11 @@ module.exports = {
             default: {
                 script: series(
                     `nps banner.clean`,
-                    `nps clean.dist`,
-                ),
+                    `nps clean.dist`
+                )
             },
             dist: {
-                script: `\"./node_modules/.bin/trash\" \"./dist\"`
+                script: rimraf('./dist')
             }
         },
         /**
@@ -154,20 +158,20 @@ module.exports = {
             default: {
                 script: series(
                     `nps copy.swagger`,
-                    `nps copy.public`,
-                ),
+                    `nps copy.public`
+                )
             },
             swagger: {
                 script: copy(
-                    '\"./src/api/swagger.json\"',
-                    '\"./dist\"',
-                ),
+                    './src/api/swagger.json',
+                    './dist'
+                )
             },
             public: {
                 script: copy(
-                    '\"./src/public/*\"',
-                    '\"./dist\"',
-                ),
+                    './src/public/*',
+                    './dist'
+                )
             }
         },
         /**
@@ -180,9 +184,9 @@ module.exports = {
             migrate: banner('migrate'),
             seed: banner('seed'),
             revert: banner('revert'),
-            clean: banner('clean'),
-        },
-    },
+            clean: banner('clean')
+        }
+    }
 };
 
 function banner(name) {
@@ -191,16 +195,16 @@ function banner(name) {
         silent: true,
         logLevel: 'error',
         description: `Shows ${name} banners to the console`,
-        script: runFast(`\"./src/lib/banner.ts\" ${name}`),
+        script: runFast(`./src/lib/banner.ts ${name}`),
     };
 }
 
 function copy(source, target) {
-    return `\"./node_modules/.bin/copyup\" ${source} ${target}`;
+    return `copyup ${source} ${target}`;
 }
 
 function run(path) {
-    return `\"./node_modules/.bin/ts-node\" ${path}`;
+    return `ts-node ${path}`;
 }
 
 function runFast(path) {

package.json

@@ -4,7 +4,7 @@
   "description": "A delightful way to building a RESTful API with NodeJs & TypeScript",
   "main": "src/app.ts",
   "scripts": {
-    "start": "\"./node_modules/.bin/nps\"",
+    "start": "nps",
     "test": "npm start test",
     "build": "npm start build"
   },