Appease the linter

Author: terrorbyte

transform/encode.go

@@ -44,7 +44,7 @@ func EncodeBase64URL(s string) string {
 	return base64.URLEncoding.EncodeToString([]byte(s))
 }
 
-// DecodeBase64 decodes base64 with standard encoding
+// DecodeBase64 decodes base64 with standard encoding.
 func DecodeBase64(s string) string {
 	decoded, err := base64.StdEncoding.DecodeString(s)
 	if err != nil {

transform/encode_test.go

@@ -4,6 +4,10 @@ import (
 	"testing"
 )
 
+const (
+	urlTestString = "Theskyabovetheportwasthecoloroftelevision,tunedtoadeadchannel.\xff\xff\xff\x3e\xfe\x00"
+)
+
 func TestURLEncodeString(t *testing.T) {
 	encoded := URLEncodeString("foo !~")
 
@@ -25,7 +29,7 @@ func TestEncodeBase64(t *testing.T) {
 }
 
 func TestEncodeBase64URL(t *testing.T) {
-	encoded := EncodeBase64URL("Theskyabovetheportwasthecoloroftelevision,tunedtoadeadchannel.\xff\xff\xff\x3e\xfe\x00")
+	encoded := EncodeBase64URL(urlTestString)
 
 	if encoded != "VGhlc2t5YWJvdmV0aGVwb3J0d2FzdGhlY29sb3JvZnRlbGV2aXNpb24sdHVuZWR0b2FkZWFkY2hhbm5lbC7___8-_gA=" {
 		t.Fatal(encoded)
@@ -37,7 +41,7 @@ func TestEncodeBase64URL(t *testing.T) {
 func TestDecodeBase64URL(t *testing.T) {
 	decoded := DecodeBase64URL("VGhlc2t5YWJvdmV0aGVwb3J0d2FzdGhlY29sb3JvZnRlbGV2aXNpb24sdHVuZWR0b2FkZWFkY2hhbm5lbC7___8-_gA=")
 
-	if decoded != "Theskyabovetheportwasthecoloroftelevision,tunedtoadeadchannel.\xff\xff\xff\x3e\xfe\x00" {
+	if decoded != urlTestString {
 		t.Fatal(decoded)
 	}
 
@@ -47,7 +51,7 @@ func TestDecodeBase64URL(t *testing.T) {
 func TestDecodeBase64URL_NoPad(t *testing.T) {
 	decoded := DecodeBase64URL("VGhlc2t5YWJvdmV0aGVwb3J0d2FzdGhlY29sb3JvZnRlbGV2aXNpb24sdHVuZWR0b2FkZWFkY2hhbm5lbC7___8-_gA")
 
-	if decoded != "Theskyabovetheportwasthecoloroftelevision,tunedtoadeadchannel.\xff\xff\xff\x3e\xfe\x00" {
+	if decoded != urlTestString {
 		t.Fatal(decoded)
 	}
 
@@ -57,7 +61,7 @@ func TestDecodeBase64URL_NoPad(t *testing.T) {
 func TestDecodeBase64URL_WayTooMuchPadding(t *testing.T) {
 	decoded := DecodeBase64URL("VGhlc2t5YWJvdmV0aGVwb3J0d2FzdGhlY29sb3JvZnRlbGV2aXNpb24sdHVuZWR0b2FkZWFkY2hhbm5lbC7___8-_gA=======")
 
-	if decoded != "Theskyabovetheportwasthecoloroftelevision,tunedtoadeadchannel.\xff\xff\xff\x3e\xfe\x00" {
+	if decoded != urlTestString {
 		t.Fatal(decoded)
 	}