Ensure that the exact block size match is not skipped and added test

Author: terrorbyte

transform/encode.go

@@ -94,7 +94,7 @@ func EncodeBase64Chunks(s string, maxChunkSize uint) []string {
 	// the chunk size calculation iterates to the best block size.
 	chunkSize := (len(s) / int(maxChunkSize)) - (len(s) / int(maxChunkSize) / 3) - 1
 	for {
-		if maxSize(chunkSize) >= int(maxChunkSize) {
+		if maxSize(chunkSize) > int(maxChunkSize) {
 			chunkSize--
 
 			break

transform/encode_test.go

@@ -38,6 +38,25 @@ func TestEncodeBase64Chunks(t *testing.T) {
 	}
 
 	t.Log(chunks)
+
+	chunks = EncodeBase64Chunks("1234567890123456789012345678901234567890", 12)
+	expected = []string{"MTIzNDU2Nzg5", "MDEyMzQ1Njc4", "OTAxMjM0NTY3", "ODkwMTIzNDU2", "Nzg5MA=="}
+	for i, c := range chunks {
+		if c != expected[i] {
+			t.Fatal(chunks)
+		}
+	}
+
+	t.Log(chunks)
+
+	chunks = EncodeBase64Chunks("1234567890123456789012345678901234567890", 13)
+	for i, c := range chunks {
+		if c != expected[i] {
+			t.Fatal(chunks)
+		}
+	}
+
+	t.Log(chunks)
 }
 
 func TestEncodeBase64Chunks_EmptyString(t *testing.T) {