-
-
Notifications
You must be signed in to change notification settings - Fork 170
Open
Labels
help wantedExtra attention is neededExtra attention is needed
Description
Reproduction
https://github.com/bgoscinski/repro-vue-compat-reactivity
Steps to reproduce the bug
- Run
npm install - Run
npm test. Test fails - Remove
'vue': '@vue/compat'alias from./vite.config.js - Run
npm testagain. Test passes 🤯
Expected behavior
Reactivity is preserved when using vue-demi with @vue/compat
Actual behavior
No/broken reactivity
Additional information
I think that vue-demi doesn't use the reactivity primitives from @vue/compat so we end up with both of these loaded at the same time:
node_modules/@vue/compat/dist/vue.cjs.jsnode_modules/@vue/reactivity/dist/reactivity.cjs.js
Because of that the component's render effect is not tracking all reactive values properly.
I'm coming from vuejs/pinia#2565 but it's still not clear for me how to properly configure aliases and I think it would be beneficial for the whole ecosystem to have this documented somewhere.
anthonyhenderson
Metadata
Metadata
Assignees
Labels
help wantedExtra attention is neededExtra attention is needed