chore: clarify isUpdating purpose to prevent recursive updates

edison1105 · edison1105 · commit a3a20afcd4e5 · 2025-12-03T15:54:59.000+08:00
diff --git a/packages/runtime-vapor/src/renderEffect.ts b/packages/runtime-vapor/src/renderEffect.ts
@@ -53,8 +53,6 @@ export class RenderEffect extends ReactiveEffect {
 
     this.job = job
     this.i = instance
-
-    // TODO recurse handling
   }
 
   fn(): void {
@@ -67,6 +65,7 @@ export class RenderEffect extends ReactiveEffect {
     }
     const prev = setCurrentInstance(instance, scope)
     if (hasUpdateHooks && instance.isMounted && !instance.isUpdating) {
+      // avoid recurse update until updateJob flushed
       instance.isUpdating = true
       instance.bu && invokeArrayFns(instance.bu)
       this.render()

Original file line number	Diff line number	Diff line change
`@@ -53,8 +53,6 @@ export class RenderEffect extends ReactiveEffect {`
`53`	`53`
`54`	`54`	`this.job = job`
`55`	`55`	`this.i = instance`
`56`		`-`
`57`		`- // TODO recurse handling`
`58`	`56`	`}`
`59`	`57`
`60`	`58`	`fn(): void {`
`@@ -67,6 +65,7 @@ export class RenderEffect extends ReactiveEffect {`
`67`	`65`	`}`
`68`	`66`	`const prev = setCurrentInstance(instance, scope)`
`69`	`67`	`if (hasUpdateHooks && instance.isMounted && !instance.isUpdating) {`
	`68`	`+ // avoid recurse update until updateJob flushed`
`70`	`69`	`instance.isUpdating = true`
`71`	`70`	`instance.bu && invokeArrayFns(instance.bu)`
`72`	`71`	`this.render()`