Refactor JSON formatting and rendering internals

Removed obsolete parameters from StructureValue and ValueFormatterState constructors to align with updated Serilog API.

Author: vonhoff

Serilog.Sinks.RichTextBox.WinForms.Colored.Test/Integration/JsonFormattingTests.cs

@@ -185,7 +185,7 @@ public void PrettyPrintJson_EmptyCollectionsFormatCorrectly()
         {
             var emptyArray = new LogEventProperty("EmptyArray", new SequenceValue(Array.Empty<LogEventPropertyValue>()));
             var emptyDict = new LogEventProperty("EmptyDict", new DictionaryValue(new Dictionary<ScalarValue, LogEventPropertyValue>()));
-            var emptyObject = new LogEventProperty("EmptyObject", new StructureValue(Array.Empty<LogEventProperty>(), null));
+            var emptyObject = new LogEventProperty("EmptyObject", new StructureValue(Array.Empty<LogEventProperty>()));
             var logEvent = new LogEvent(DateTimeOffset.Now, LogEventLevel.Information, null, _parser.Parse("Array: {EmptyArray:j}, Dict: {EmptyDict:j}, Object: {EmptyObject:j}"), new[] { emptyArray, emptyDict, emptyObject });
 
             var options = new RichTextBoxSinkOptions(

Serilog.Sinks.RichTextBox.WinForms.Colored/Sinks/RichTextBoxForms/Formatting/JsonValueFormatter.cs

@@ -29,7 +29,7 @@ namespace Serilog.Sinks.RichTextBoxForms.Formatting
 {
     public class JsonValueFormatter : ValueFormatter
     {
-        private readonly StringBuilder _literalBuilder = new(64);
+        private readonly StringBuilder _literalBuilder = new();
         private readonly StringBuilder _scalarBuilder = new();
         private readonly StringBuilder _jsonStringBuilder = new();
 
@@ -39,7 +39,7 @@ public JsonValueFormatter(RichTextBoxSinkOptions options) : base(options)
 
         protected override ValueFormatterState CreateInitialState(IRtfCanvas canvas, string format, bool isLiteral)
         {
-            return new ValueFormatterState(canvas, format, isLiteral, 0, Options.SpacesPerIndent, true);
+            return new ValueFormatterState(canvas, format, isLiteral, 0, Options.SpacesPerIndent);
         }
 
         protected override bool VisitScalarValue(ValueFormatterState state, ScalarValue scalar)

Serilog.Sinks.RichTextBox.WinForms.Colored/Sinks/RichTextBoxForms/Rendering/EventPropertyTokenRenderer.cs

@@ -30,6 +30,7 @@ public class EventPropertyTokenRenderer : ITokenRenderer
     {
         private readonly RichTextBoxSinkOptions _options;
         private readonly PropertyToken _token;
+        private readonly StringBuilder _stringBuilder = new();
 
         public EventPropertyTokenRenderer(PropertyToken token, RichTextBoxSinkOptions options)
         {
@@ -51,14 +52,14 @@ public void Render(LogEvent logEvent, IRtfCanvas canvas)
             }
             else
             {
-                var sb = new StringBuilder();
+                _stringBuilder.Clear();
 
-                using (var writer = new StringWriter(sb))
+                using (var writer = new StringWriter(_stringBuilder))
                 {
                     propertyValue.Render(writer, _token.Format, _options.FormatProvider);
                 }
 
-                _options.Theme.Render(canvas, StyleToken.SecondaryText, sb.ToString());
+                _options.Theme.Render(canvas, StyleToken.SecondaryText, _stringBuilder.ToString());
             }
         }
     }