Refactor signal handling in RichTextBoxSink to improve thread synchronization

vonhoff · vonhoff · commit a24bff9b38f8 · 2025-07-13T09:43:38.000+02:00
diff --git a/Serilog.Sinks.RichTextBox.WinForms.Colored/Sinks/RichTextBoxForms/RichTextBoxSink.cs b/Serilog.Sinks.RichTextBox.WinForms.Colored/Sinks/RichTextBoxForms/RichTextBoxSink.cs
@@ -111,7 +111,6 @@ private void ProcessMessages(CancellationToken token)
             while (!token.IsCancellationRequested)
             {
                 _signal.WaitOne();
-
                 if (token.IsCancellationRequested)
                 {
                     break;
@@ -128,12 +127,8 @@ private void ProcessMessages(CancellationToken token)
                     }
                 }
 
-                while (_signal.WaitOne(0))
-                {
-                }
-
+                _signal.Reset();
                 _buffer.TakeSnapshot(snapshot);
-
                 builder.Clear();
                 foreach (var evt in snapshot)
                 {

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,6 @@ private void ProcessMessages(CancellationToken token)`
`111`	`111`	`while (!token.IsCancellationRequested)`
`112`	`112`	`{`
`113`	`113`	`_signal.WaitOne();`
`114`		`-`
`115`	`114`	`if (token.IsCancellationRequested)`
`116`	`115`	`{`
`117`	`116`	`break;`
`@@ -128,12 +127,8 @@ private void ProcessMessages(CancellationToken token)`
`128`	`127`	`}`
`129`	`128`	`}`
`130`	`129`
`131`		`- while (_signal.WaitOne(0))`
`132`		`- {`
`133`		`- }`
`134`		`-`
	`130`	`+ _signal.Reset();`
`135`	`131`	`_buffer.TakeSnapshot(snapshot);`
`136`		`-`
`137`	`132`	`builder.Clear();`
`138`	`133`	`foreach (var evt in snapshot)`
`139`	`134`	`{`